Fix displaying errors when importing of a report fails#5406
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Add data type shape for the handleImportReport function and change xml_file to a File for the ReportCommand import method. This ensures the props are passed correctly when importing a report.
Don't use the onError handler and let the dialog handle the error cases instead to show possible errors of the request in the dialog.
bjoernricks
force-pushed
the
report-import-error-handling
branch
from
86b0971 to
7095842
Compare
…two tasks If there is only one or even no task available disable the task selection in the report import dialog because the user can't change it.
ozgen
reviewed
Jul 10, 2026
ozgen
approved these changes
Jul 10, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5406 +/- ##
=======================================
Coverage 80.95% 80.95%
=======================================
Files 1269 1269
Lines 33070 33070
Branches 9941 9941
=======================================
Hits 26771 26771
Misses 5617 5617
Partials 682 682 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix displaying errors when importing of a report fails
Why
Don't use the onError handler and let the dialog handle the error cases
instead to show possible errors of the request in the dialog.
References
https://jira.greenbone.net/browse/GEA-1751