Remove onReportImportError handler from TaskComponent#5407
Merged
Conversation
Setting the onReportImportError handler may result in an unexpected behavior of the ReportImportDialog because it would close despite of an error occurred and maybe no error is displayed. Therefore it is better to always let the dialog handle and display the error by removing the callback prop completely.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
ozgen
approved these changes
Jul 10, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5407 +/- ##
==========================================
- Coverage 80.95% 80.95% -0.01%
==========================================
Files 1269 1269
Lines 33070 33071 +1
Branches 9941 9897 -44
==========================================
Hits 26771 26771
- Misses 5617 5618 +1
Partials 682 682 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove onReportImportError handler from TaskComponent
Why
Setting the onReportImportError handler may result in an unexpected behavior of the ReportImportDialog because it would close despite of an error occurred and maybe no error is displayed. Therefore it is better to always let the dialog handle and display the error by removing the callback prop completely.