Conversation
One-shot diagnostics in the compile job to capture node/npm versions, ignore-scripts config, ELECTRON_SKIP_BINARY_DOWNLOAD, and install.js behavior on the runner. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
electron's postinstall extracts dist/ but exits before writing path.txt on Node 24, so index.js/electron-builder treat it as failed. Write path.txt after running the installer. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
electron's postinstall exits mid-extract on Node 24, leaving the binary and path.txt missing. Replace it with a fully-awaited download+extract so the binary is reliably present for the build and electron-builder. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
A floating promise does not keep Node 24's event loop alive, so electron's postinstall (and inline variants) exit before the binary extracts. Use a helper script with top-level await so the process waits for completion. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@electron/get's downloadArtifact promise never settles on Node 24 (exit 13, unsettled top-level await), so the binary never installs. Download the release zip with Node's native fetch + extract-zip instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Node 24 exits as soon as the loop is momentarily empty, before electron's download/extract promises settle. Keep a timer open until they do. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
extract-zip hangs on Node 24 (never settles), like @electron/get. Do the download+extract with synchronous shell tools so there is no async to stall. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
git-bash tar is GNU tar (mangles C: paths, can't read zips). Use PowerShell Expand-Archive on Windows; unzip on posix. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The install helper downloads to a temp dir, so caching ~/.cache/electron no longer feeds it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
electron 42 uses @electron/get@5 (native fetch) which installs cleanly on Node 24, so electron's own postinstall works and the custom CI install script is no longer needed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.