Skip to content

chao: grant access to policy/poddisruptionbudgets#143

Merged
jacob-gremlin merged 1 commit into
masterfrom
EN-10918-support-pdb-detected-risk
Jun 25, 2026
Merged

chao: grant access to policy/poddisruptionbudgets#143
jacob-gremlin merged 1 commit into
masterfrom
EN-10918-support-pdb-detected-risk

Conversation

@jacob-gremlin

Copy link
Copy Markdown
Contributor

chao: grant access to policy/poddisruptionbudgets

Adds list/watch on policy/v1.PodDisruptionBudget to the gremlin-watcher ClusterRole. Pairs with the deploy/chao.yml change in gremlin/chao#331.

Why

Chao now watches PodDisruptionBudgets so the service-side detected-risk engine can evaluate Kubernetes PodDisruptionBudget Missing (EN-10918). Without the matching RBAC rule on the customer's cluster, chao's startup probe fails on policy/v1.poddisruptionbudgets, the agent emits the DD009 error code and skips the PDB informer, and the risk silently has no data to evaluate against.

What changes

  • gremlin/templates/chao-service-account.yaml — adds the rule, matching the pattern of existing access-gated resources like autoscaling/horizontalpodautoscalers and networking.k8s.io/ingresses.
  • gremlin/Chart.yaml — bumps chart version 0.25.3 → 0.25.4 to reflect the changed RBAC surface.

Risk

Low. Additive RBAC change; doesn't remove or modify existing permissions. Clusters

@jacob-gremlin jacob-gremlin requested review from a team as code owners June 25, 2026 15:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds RBAC permissions needed for chao to watch PodDisruptionBudgets, and bumps the Helm chart version to reflect the RBAC surface change.

Changes:

  • Extend the gremlin-watcher ClusterRole with access to policy/poddisruptionbudgets.
  • Bump chart version 0.25.30.25.4.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
gremlin/templates/chao-service-account.yaml Adds ClusterRole permissions for policy/poddisruptionbudgets to support the new informer.
gremlin/Chart.yaml Increments chart version to reflect the RBAC change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +36 to +38
- apiGroups: ["policy"]
resources: ["poddisruptionbudgets"]
verbs: ["get", "watch", "list"]
@jacob-gremlin jacob-gremlin merged commit 3db8177 into master Jun 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants