Skip to content

One-line error messages from the compiler front end need new-line #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robinheghan merged 2 commits into from
Jan 26, 2026
Merged

One-line error messages from the compiler front end need new-line #363

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0f4606
One-line error messages from the compiler front end need new-line
gilramir Jan 26, 2026
99991a2
Remove newly-added endWithErrorLine and just append "\n"
gilramir Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Main.gren
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,10 @@ parseUserArgs model compilerPath =
|> Stream.Log.string model.stderr
|> Task.map (\_ -> Task.execute <| Node.exitWithCode 1)

endWithErrorLine stringErr =
Stream.Log.line model.stderr stringErr
|> Task.map (\_ -> Task.execute <| Node.exitWithCode 1)

endWithErrorString stringErr =
Stream.Log.string model.stderr stringErr
|> Task.map (\_ -> Task.execute <| Node.exitWithCode 1)
Expand All @@ -352,7 +356,7 @@ parseUserArgs model compilerPath =
in
when CLI.Parser.run model.args CliParser.parser is
CLI.Parser.UnknownCommand commandName ->
endWithErrorString ("I don't recognize this command: " ++ commandName)
endWithErrorLine ("I don't recognize this command: " ++ commandName)
Comment thread
robinheghan marked this conversation as resolved.
Outdated
|> Task.perform RunCmd

CLI.Parser.BadFlags err ->
Expand Down