Merged
Conversation
This is the same fix for using versioned symbols with link time optimization that is already applied in globus-common. After updating to gcc 16 it is needed for globus-gsi-proxy-core too.
Member
|
Nice. Maybe best to make a new candidate tag to have this included in the upcoming maintenance release. I'll take care of that once the one test works through and it's merged. |
fscheiner
approved these changes
Jan 8, 2026
Member
fscheiner
left a comment
fscheiner
left a comment
There was a problem hiding this comment.
Looks good to me. Let's merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same fix for using versioned symbols with link time optimization that is already applied in globus-common. After updating to gcc 16 it is needed for globus-gsi-proxy-core too.
Compare:
gct/common/source/configure.ac
Line 173 in 3521a3c
gct/common/source/library/Makefile.am
Lines 169 to 171 in 3521a3c