Refactor/cleanup#47
Merged
Merged
Conversation
rule19a declared rule: 19, colliding with rule19 and mislabeling its own errors.
Workers spawned in applySetRowDataEffect/applySetRawDataEffect were never terminated, leaking one per dispatch. Also drops canUndo/canRedo from AgsState — no reducer ever wrote them; components already derive these from past.length/future.length.
--muted was "207 86 95%" / "207 90 3%" — invalid HSL, saturation missing its %. hsl(var(--muted)) silently rendered wrong; Tailwind utilities like bg-muted/50 were unaffected by the JS-side workaround in getCSSVariable.
Link > Button > div nested an interactive element inside another, which is invalid HTML. Button now wraps the Link via asChild instead.
Left over from development in GridView (fires every render) and useGridTheme (fires on every CSS var lookup).
themeDemo had an empty dependency array but read CSS variables that change with theme. The object is cheap to build, so drop the memo entirely rather than chase a correct dep list.
"happy to overwrite ts here" wasn't meaningful to a reader.
Bump ags target/lib to ES2019 — Object.fromEntries was flagged as missing under ES2018 lib types despite being valid. Switch both packages to moduleResolution: bundler to match how imports actually resolve under Next.js/modern bundlers, including package.json exports maps.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
Please link and relevant issues.
Type of Change
Please delete options that are not relevant.
Checklist
Screenshots (if applicable)
Add screenshots to help explain the changes (if applicable).
Additional Context
Add any other context or screenshots about the pull request here.