Skip to content

Fix: CurvedAnimation instances not disposed (fixes #155) #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
winter-cw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: CurvedAnimation instances not disposed (fixes #155) #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/src/flutter_animate.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,19 @@ class EffectEntry {
Duration get end => delay + duration;

/// Builds a sub-animation based on the properties of this entry.
///
/// Uses [CurveTween] with [Animation.drive] instead of [CurvedAnimation]
/// to avoid creating a disposable object on every call. This method is
/// invoked from [Effect.build] during the widget build phase, so using
/// [CurvedAnimation] would leak instances since they are never disposed.
Animation<double> buildAnimation(
AnimationController controller, {
Curve? curve,
}) {
int ttlT = controller.duration?.inMicroseconds ?? 0;
int beginT = begin.inMicroseconds, endT = end.inMicroseconds;
return CurvedAnimation(
parent: controller,
curve: Interval(beginT / ttlT, endT / ttlT, curve: curve ?? this.curve),
return controller.drive(
CurveTween(curve: Interval(beginT / ttlT, endT / ttlT, curve: curve ?? this.curve)),
);
}
}