Skip to content

Only warn about missing features for mainstream modern browsers#490

Open
lionel-rowe wants to merge 1 commit into
gskinner:masterfrom
lionel-rowe:update-jsfuture-warnings
Open

Only warn about missing features for mainstream modern browsers#490
lionel-rowe wants to merge 1 commit into
gskinner:masterfrom
lionel-rowe:update-jsfuture-warnings

Conversation

@lionel-rowe

Copy link
Copy Markdown

Closes #489:

IE is officially dead, so maybe these warnings should be removed for features supported in all current browsers, such as the u flag.

Methodology: check caniuse for each feature, only including mainstream modern browsers (no IE, no Opera Mini, and ignoring the various Chinese browsers, which are all based on mainstream modern browser engines).

Sources:

Results: only neglookbehind and poslookbehind are missing, thanks to iOS Safari. Presumably upcoming features like RegExp v flag will also lack comprehensive support for a while after they're officially added to the spec.

@gskinner

Copy link
Copy Markdown
Owner

@lionel-rowe - thanks for this PR. Good timing too, as I'm currently planning to jump back into RegExr maintenance / updates beginning early next week, after a long hiatus. I'll take a look then, and let you know if I have any specific feedback, but at a glance this looks good.

@lionel-rowe

Copy link
Copy Markdown
Author

@gskinner Even better timing — I just noticed https://caniuse.com/js-regexp-lookbehind has been updated, and it looks like iOS Safari 16.4 will ship with support for neglookbehind and poslookbehind! 🎉

Will leave PR as-is for now though as iOS Safari 16.4 is still in beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove most "may not be supported in all browsers" warnings?

2 participants