Skip to content

Run OptimizedOnlyCompilerSuite when draft is disabled #10254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
niloc132 wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −6
Open

Run OptimizedOnlyCompilerSuite when draft is disabled #10254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e49146
Run OptimizedOnlyCompilerSuite when draft is disabled
niloc132 Jan 24, 2026
6ab91a2
Merge branch 'main' into 10253-run-optimized-only-suite
niloc132 Mar 18, 2026
e8e93a3
Enable optimized tests for Java 21 in CI
niloc132 Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/full-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,10 @@ jobs:
ANT_OPTS='-Dfile.encoding=UTF8 -Xmx2g' \
GWT_VERSION=HEAD-SNAPSHOT
# Run the ant tasks, disabling watchFileChanges to work around a github actions limitation
# Only Java 21 will run optimized tests
ant clean test dist doc \
-Dtest.jvmargs='-ea -Dgwt.watchFileChanges=false' \
-Dtest.web.htmlunit.disable=true \
-Dtest.web.htmlunit.disable=${{ matrix.java-version != '21' }} \
-Dtest.nometa.htmlunit.disable=true \
-Dtest.emma.htmlunit.disable=true

Expand Down
6 changes: 3 additions & 3 deletions user/build.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<property name="emma.merged.out" value="${junit.out}/emma-coverage"/>

<property name="gwt.junit.testcase.web.includes" value="${gwt.junit.testcase.includes}" />
<property name="gwt.junit.testcase.web.excludes" value="**/*JreSuite.class,**/OptimizedOnly*" />
<property name="gwt.junit.testcase.web.excludes" value="**/*JreSuite.class" />

<!-- Disable legacy dev mode test on Java 9 and above -->
<property name="test.dev.htmlunit.disable" value="true" />
Expand Down Expand Up @@ -433,7 +433,7 @@
value="${test.args.web.selenium} -draftCompile"/>
<fileset id="test.draft.selenium.tests" dir="${javac.junit.out}"
includes="${gwt.junit.testcase.web.includes}"
excludes="${gwt.junit.testcase.web.excludes}"/>
excludes="${gwt.junit.testcase.web.excludes},**/OptimizedOnly*"/>
<gwt.junit test.name="test.draft.selenium"
test.args='${test.draft.selenium.args}'
test.jvmargs="${test.jvmargs}"
Expand Down Expand Up @@ -524,7 +524,7 @@
unless="test.draft.htmlunit.disable">
<fileset id="test.draft.htmlunit.tests" dir="${javac.junit.out}"
includes="${gwt.junit.testcase.web.includes}"
excludes="${gwt.junit.testcase.web.excludes}"/>
excludes="${gwt.junit.testcase.web.excludes},**/OptimizedOnly*"/>
<gwt.junit test.name="test.draft.htmlunit"
test.args="${test.args.web.htmlunit} -draftCompile"
test.jvmargs="${test.jvmargs}"
Expand Down
4 changes: 2 additions & 2 deletions user/test/com/google/gwt/dev/jjs/OptimizedOnlyCompilerSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import com.google.gwt.dev.jjs.optimized.ArrayListOptimizationTest;
import com.google.gwt.dev.jjs.optimized.ArrayStoreOptimizationTest;
import com.google.gwt.dev.jjs.optimized.CastOptimizationTest;
import com.google.gwt.dev.jjs.optimized.JsOverlayMethodOptimizationTest;
import com.google.gwt.dev.jjs.optimized.SpecializationTest;
import com.google.gwt.dev.jjs.optimized.StringOptimizationTest;
import com.google.gwt.dev.jjs.optimized.UncheckedCastOptimizationTest;
Expand All @@ -41,7 +40,8 @@ public static Test suite() {
suite.addTestSuite(ArrayStoreOptimizationTest.class);
suite.addTestSuite(StringOptimizationTest.class);
suite.addTestSuite(CastOptimizationTest.class);
suite.addTestSuite(JsOverlayMethodOptimizationTest.class);
// Disabled until #10147 is resolved.
// suite.addTestSuite(JsOverlayMethodOptimizationTest.class);
suite.addTestSuite(SpecializationTest.class);
suite.addTestSuite(HasNoSideEffectsTest.class);
suite.addTestSuite(UncheckedCastOptimizationTest.class);
Expand Down
Loading