Skip to content

Minify boolean and numeric literals in obfuscated mode #10291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zbynek wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Minify boolean and numeric literals in obfuscated mode #10291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f50f053
Minify boolean and numeric literals in obfuscated mode
zbynek Mar 5, 2026
edd9445
Avoid String to char[] conversion, remove log message
zbynek Mar 6, 2026
271e29c
Avoid double serialization, consistent naming
zbynek Mar 6, 2026
7adbee5
Fix failing test
zbynek Mar 10, 2026
cca743f
Inline short bool values
zbynek Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@
import com.google.gwt.dev.js.JsStackEmulator;
import com.google.gwt.dev.js.JsStaticEval;
import com.google.gwt.dev.js.JsSymbolResolver;
import com.google.gwt.dev.js.JsToStringGenerationVisitor;
import com.google.gwt.dev.js.JsUnusedFunctionRemover;
import com.google.gwt.dev.js.JsVerboseNamer;
import com.google.gwt.dev.js.SizeBreakdown;
Expand Down Expand Up @@ -772,7 +773,9 @@ private void generateJavaScriptCode(JavaToJavaScriptMap jjsMap, String[] jsFragm
DefaultTextOutput out = new DefaultTextOutput(!options.isIncrementalCompileEnabled() &&
options.getOutput().shouldMinimize());
JsReportGenerationVisitor v = new JsReportGenerationVisitor(out, jjsMap,
options.isJsonSoycEnabled());
options.isJsonSoycEnabled(),
new JsToStringGenerationVisitor.PrintOptions(false,
options.getOutput() == JsOutputOption.OBFUSCATED));
v.accept(jsProgram.getFragmentBlock(i));

StatementRanges statementRanges = v.getStatementRanges();
Expand Down
4 changes: 2 additions & 2 deletions dev/core/src/com/google/gwt/dev/js/JsReportGenerationVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ public class JsReportGenerationVisitor extends
private List<JsNode> parentStack = Lists.newArrayList();

public JsReportGenerationVisitor(TextOutput out, JavaToJavaScriptMap map,
boolean needSourcemapNames) {
super(out, map);
boolean needSourcemapNames, PrintOptions options) {
super(out, map, options);
this.out = out;
this.needSourcemapNames = needSourcemapNames;
}
Expand Down
6 changes: 3 additions & 3 deletions dev/core/src/com/google/gwt/dev/js/JsSourceGenerationVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ public JsSourceGenerationVisitor(TextOutput out) {
/**
* Generate the output source code using short or long identifiers.
*
* @param useLongIdents if true, emit all identifiers in long form
* @param options minification options
*/
public JsSourceGenerationVisitor(TextOutput out, boolean useLongIdents) {
super(out, useLongIdents);
public JsSourceGenerationVisitor(TextOutput out, PrintOptions options) {
super(out, options);
}

@Override
Expand Down
4 changes: 2 additions & 2 deletions dev/core/src/com/google/gwt/dev/js/JsSourceGenerationVisitorWithSizeBreakdown.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ public class JsSourceGenerationVisitorWithSizeBreakdown extends JsSourceGenerati
private final Map<JsName, Integer> sizeMap = new HashMap<JsName, Integer>();

public JsSourceGenerationVisitorWithSizeBreakdown(TextOutput out,
JavaToJavaScriptMap javaToJavaScriptMap) {
super(out);
JavaToJavaScriptMap javaToJavaScriptMap, PrintOptions options) {
super(out, options);
this.out = out;
this.map = javaToJavaScriptMap;
}
Expand Down
Loading
Loading