Dave Scotese javascript#205
Open
dscotese wants to merge 8 commits into
Open
Conversation
…l other javascript in the <head> has already been loaded. No tests have been added.
Added code to allow admin to add a Javascript file that runs after al…
In Firefox 60.0.2 (64-bit), selecting the descriptor type "Option" did not cause option entry fields to be displayed. I used the console to show the hidden (by default) div and was then able to create an options descriptor. This commit is so that Heroku will pick up the change I believe will allow us to create descriptors of type "Option."
Fixed bug preventing options fields from showing when a descriptor of type "Option" is added.
Dangerous, I know, but we can just shut it and fix it later if it gets ugly. It's a free Filestack account right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch contains one of the items on the list of things Foster For Life wanted to add (Javascript to load after existing javascript in ).