-
-
Notifications
You must be signed in to change notification settings - Fork 859
DO NOT REVIEW: GitHub Actions: Implement ESlint #5024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ronaldpaek
wants to merge
15
commits into
hackforla:gh-pages
Choose a base branch
from
ronaldpaek:github-actions-implement-eslint-1442
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
bd8be66
Add eslint github action
ronaldpaek 68c5ec3
Add eslint config file
ronaldpaek f236f60
Update eslint github action
ronaldpaek c666726
Update eslint github file
ronaldpaek 1b76594
Fix eslint github action
ronaldpaek c931435
Update eslintrc.json file
ronaldpaek f106b98
Update linter-js.yml file
ronaldpaek 2a69d0e
Rename linter-js.yml to lint-js.yml
ronaldpaek 336093b
Add test file
ronaldpaek 4364595
Remove bad file
ronaldpaek e1c1223
Update rules on eslintrc.json file
ronaldpaek d8da4c9
Create wins.liquid file
ronaldpaek 0cafcdb
Update wins.js file remove liquid
ronaldpaek 62900f5
Update lint-js.yml file to test change
ronaldpaek 738c46c
Separate liquid and js for hamburger-nav
ronaldpaek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "env": { | ||
| "browser": true, | ||
| "es2021": true, | ||
| "node": true | ||
| }, | ||
| "extends": "eslint:recommended", | ||
| "parserOptions": { | ||
| "ecmaVersion": "latest", | ||
| "sourceType": "module" | ||
| }, | ||
| "rules": { | ||
|
|
||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| name: Lint JS | ||
|
|
||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [gh-pages] | ||
| push: | ||
| branches: [gh-pages] | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Lint JS | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout Code | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| # Full git history is needed to get a proper list of changed files within `super-linter` | ||
| fetch-depth: 0 | ||
|
|
||
| # Run Linter against code base # | ||
| - name: Lint JS | ||
| uses: github/super-linter@v5.0.0 | ||
| env: | ||
| VALIDATE_ALL_CODEBASE: false | ||
| DEFAULT_BRANCH: gh-pages | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
|
|
||
| LINTER_RULES_PATH: / | ||
| JAVASCRIPT_ES_CONFIG_FILE: .eslintrc.json | ||
| VALIDATE_JAVASCRIPT_ES: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| const unusedVar = () => { | ||
| const foo = 1; | ||
| const bar = 2; | ||
| const baz = 3; | ||
|
||
| return bar; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.