Skip to content

Replace Twitter bird logo with X logo in footer#8600

Open
viet456 wants to merge 2 commits intohackforla:gh-pagesfrom
viet456:update-twitter-logo-8593
Open

Replace Twitter bird logo with X logo in footer#8600
viet456 wants to merge 2 commits intohackforla:gh-pagesfrom
viet456:update-twitter-logo-8593

Conversation

@viet456
Copy link
Copy Markdown
Member

@viet456 viet456 commented Apr 1, 2026

Fixes #8593

What changes did you make?

  • Added _includes/svg/icon-x.svg with the new X logo SVG (no hardcoded fill color)
  • Updated _data/navigation/social.yml to reference the new icon path, name, and X.com link
  • Added class="icon icon-x" to the SVG element so the existing footer CSS correctly renders it as white

Why did you make the changes (we will use this info to test)?

  • The Twitter/X rebrand happened in 2023 and the footer still showed the old Twitter bird logo, making the site look outdated. Updating to the X logo keeps the website current with the platform's branding.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

image
pre

Visuals after changes are applied post

image

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b viet456-update-twitter-logo-8593 gh-pages
git pull https://github.com/viet456/website.git update-twitter-logo-8593

@github-actions github-actions bot added Feature: Administrative Administrative chores etc. role: front end Tasks for front end developers Complexity: Medium P-Feature: Footer size: 0.25pt Can be done in 0.5 to 1.5 hours ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization labels Apr 1, 2026
@viet456
Copy link
Copy Markdown
Member Author

viet456 commented Apr 1, 2026

This PR includes the renaming of the branch to include the issue number

Copy link
Copy Markdown
Member

@jjam02 jjam02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review ETA: 10:30 PM 4/3/26
Availability: M/W/F: 1pm-11pm T:8pm-11pm Th: 7-11pm Sat/Sun: 2pm-7pm all times in PST

Copy link
Copy Markdown
Member

@jjam02 jjam02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great on the original issue and the updates you made.

One accessibility question I had: the current aria-label uses the value from the YAML file (“X”). For screen reader users, “X” by itself can be ambiguous and may not clearly indicate the X platform.

Typically, a more descriptive label is used (e.g., “X (formerly Twitter)” or “Follow us on X”) to provide better context.

Not sure if this is outside of the scope of this issue and should be handled in a separate issue would be a question for a dev lead.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Apr 4, 2026
…ld to social.yml and updating footer.html to use item.aria_label with fallback to item.name
@viet456
Copy link
Copy Markdown
Member Author

viet456 commented Apr 4, 2026

Thanks for the feedback @jjam02 . I added an aria_label field to social.yml for the X link and updated footer.html to use item.aria_label | default: item.name so other social links aren't affected. Let me know if this looks good or not

@viet456 viet456 requested review from jjam02 and t-will-gillis April 4, 2026 05:54
Copy link
Copy Markdown
Member

@jjam02 jjam02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes I no longer see any potential issues. good job!

@mocodesss mocodesss self-requested a review April 8, 2026 04:50
@mocodesss
Copy link
Copy Markdown
Member

PR review eta 4/8 eod

Copy link
Copy Markdown
Member

@mocodesss mocodesss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR notes:

###Done correctly:

  • The merge from and to branches have been correctly set.
  • The issue has been correctly linked.
  • In the issue, you've correctly assigned yourself.
  • The CodeQL alerts have been correctly checked off.
  • In the issue, you've correctly set the project status.
  • In the issue, action items have correctly been checked off.
  • Visuals before/after changes are applied.

###Comment:
Looks great! God descriptive "why" and nice change to the aria label!

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium Feature: Administrative Administrative chores etc. P-Feature: Footer ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Status: PRs ✅ waiting for merge team

Development

Successfully merging this pull request may close these issues.

Update Twitter logo to X logo in footer

3 participants