Replace Twitter bird logo with X logo in footer#8600
Replace Twitter bird logo with X logo in footer#8600viet456 wants to merge 2 commits intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
This PR includes the renaming of the branch to include the issue number |
jjam02
left a comment
There was a problem hiding this comment.
Review ETA: 10:30 PM 4/3/26
Availability: M/W/F: 1pm-11pm T:8pm-11pm Th: 7-11pm Sat/Sun: 2pm-7pm all times in PST
jjam02
left a comment
There was a problem hiding this comment.
Everything looks great on the original issue and the updates you made.
One accessibility question I had: the current aria-label uses the value from the YAML file (“X”). For screen reader users, “X” by itself can be ambiguous and may not clearly indicate the X platform.
Typically, a more descriptive label is used (e.g., “X (formerly Twitter)” or “Follow us on X”) to provide better context.
Not sure if this is outside of the scope of this issue and should be handled in a separate issue would be a question for a dev lead.
…ld to social.yml and updating footer.html to use item.aria_label with fallback to item.name
|
Thanks for the feedback @jjam02 . I added an |
jjam02
left a comment
There was a problem hiding this comment.
thanks for the changes I no longer see any potential issues. good job!
|
PR review eta 4/8 eod |
mocodesss
left a comment
There was a problem hiding this comment.
PR notes:
###Done correctly:
- The merge from and to branches have been correctly set.
- The issue has been correctly linked.
- In the issue, you've correctly assigned yourself.
- The CodeQL alerts have been correctly checked off.
- In the issue, you've correctly set the project status.
- In the issue, action items have correctly been checked off.
- Visuals before/after changes are applied.
###Comment:
Looks great! God descriptive "why" and nice change to the aria label!
Fixes #8593
What changes did you make?
_includes/svg/icon-x.svgwith the new X logo SVG (no hardcoded fill color)_data/navigation/social.ymlto reference the new icon path, name, and X.com linkclass="icon icon-x"to the SVG element so the existing footer CSS correctly renders it as whiteWhy did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied