Stellarium 26.2

[alex-w]

When submitting changes to Haikuports, please check the following:

• You are not a robot.
• The modified recipe was confirmed to build on your Haiku machine.
• The license and copyright information in modified recipes are correct.
• The recipe follows one of the templates from https://github.com/haikuports/haikuporter/tree/master/generic (in particular, the fields are in the right order).
• The recipe is in the right category (matching Gentoo's overlays if the recipe is available there for example, use https://gpo.zugaina.org to search for existing recipes in Gentoo).

See the guidelines for more details.

[alex-w]

This is a very sad, but I can’t compile Stellarium with QXlsx anymore due cmake error :(

P.S. Checked with qxlsx 1.5.0 and 1.5.1

[Begasus]

I'll check on this, but the source is quite large, so wont be hitting anything real fast, what is the error you are running into?

[alex-w]

I'll check on this, but the source is quite large, so wont be hitting anything real fast, what is the error you are running into?

Currently qxlsx is disabled, but when I enable it (see config option and removed dependency in pull request) I got cmake error at configuration stage: log.txt

P.S. Qt6::GuiPrivate is important for QXlsx package

[Begasus]

My first guess is (looking at the source at GH) that your CMakeList.txt needs the "fix" done in Qxlsx also needs to be applied there, so it should find the Qt6Gui private headers.
Qt6Gui is part of the same package as Qt6Core (eg qt6_base(_devel)).
Should be added somewhere after:
https://github.com/Stellarium/stellarium/blob/master/CMakeLists.txt#L29

[Begasus]

This fixes the detection for Qt6Gui:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index aeb0e5b..90e7643 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -26,11 +26,14 @@ SET(STELLARIUM_RELEASE_BUILD 1 CACHE BOOL "Set 1 to build as an official release
 ########### Detect Qt version
 SET(ENABLE_QT6 1 CACHE BOOL "Whether to try building with Qt6. If Qt6 is not found, Qt5 will be used.")
 IF(ENABLE_QT6)
-     FIND_PACKAGE(Qt6 COMPONENTS Core QUIET)
+     FIND_PACKAGE(Qt6 COMPONENTS Core Gui QUIET)
 ENDIF()
 if (NOT Qt6_FOUND)
      FIND_PACKAGE(Qt5 REQUIRED COMPONENTS Core)
 ENDIF()
+if(Qt6Gui_VERSION VERSION_GREATER_EQUAL "6.10.0")
+    find_package(Qt6 REQUIRED COMPONENTS GuiPrivate)
+endif()
 
 # Activate this to error on all things deprecated in 5.15
 #add_compile_definitions("QT_DISABLE_DEPRECATED_BEFORE=0x050F00")

[Begasus]

Pushed a revbump for qxslx to fix the build. #14294

QtExcel/QXlsx#465

[alex-w]

Thank you very much for the patch - I'm a bit reworked it and added into upstream.

Is it acceptable to merge Stellarium without XLSX support at the moment?

[Begasus]

Is it acceptable to merge Stellarium without XLSX support at the moment?

It's your work, if you are fine with it then we can merge this as it is, just give the green light. :)

[alex-w]

It's OK for me, thanks!