Add optional icu4x unicode data#407
Merged
Merged
Conversation
dfrg
commented
Jul 8, 2026
Comment on lines
-19
to
-21
| pub fn rb_flag_range(x: u32, y: u32) -> u32 { | ||
| (x < y) as u32 + rb_flag(y + 1) - rb_flag(x) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This port from HB of static_assert_expr((x) < (y)) + FLAG((y) + 1) - FLAG(x) wasn't quite right :)
behdad
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
icufeature that pulls in theicu_propertiesandicu_normalizercrates to provide Unicode support for general category, script, canonical combining class, mirroring, compose and decompose (the HB unicode funcs set).When the feature is enabled, we use the ICU functions and our built-in UCD is excluded from the build.
Also includes a little bit of reorganization and cleanup of the unicode types.