Skip to content

add and correct links in doc#74

Merged
khaledhosny merged 2 commits into
harfbuzz:mainfrom
Udi-Fogiel:main
Jun 23, 2026
Merged

add and correct links in doc#74
khaledhosny merged 2 commits into
harfbuzz:mainfrom
Udi-Fogiel:main

Conversation

@Udi-Fogiel

Copy link
Copy Markdown
Contributor

I think there are missing functions in the doc and API coverage as well.
After a quick comparison I think these are missing:

hb_buffer_add (Buffer:add)
hb_buffer_clear_contents (Buffer:clear_contents)
hb_buffer_reset (Buffer:reset)
hb_buffer_pre_allocate (Buffer:pre_allocate)
hb_buffer_get_flags / hb_buffer_set_flags
hb_buffer_get_invisible_glyph / hb_buffer_set_invisible_glyph
hb_buffer_get_replacement_codepoint / hb_buffer_set_replacement_codepoint

should they be added to luadoc and the done.txt files? should done.txt also include constants (enum values) or just functions?

@khaledhosny

Copy link
Copy Markdown
Contributor

should they be added to luadoc

Yes, please.

and the done.txt files? should done.txt also include constants (enum values) or just functions?

I don’t really check that file often. Maybe we should retire or find a way to generate it automatically. I don’t want to manually maintain it.

@Udi-Fogiel

Copy link
Copy Markdown
Contributor Author

I don’t really check that file often. Maybe we should retire or find a way to generate it automatically. I don’t want to manually maintain it.

Is there a need for it if there is the html produced from ldoc? If so, and we assume that the luadoc file covers everything, then it can be parsed to generate a summery of what is covered.

@Udi-Fogiel

Udi-Fogiel commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Or a summery of what is covered could be added to the doc itself

@khaledhosny

Copy link
Copy Markdown
Contributor

Or a summery of what is covered could be added to the doc itself

I don’t want to manually maintain such a list (HarfBuzz API is growing, so the list is not static).

@khaledhosny
khaledhosny merged commit 53b9879 into harfbuzz:main Jun 23, 2026
2 checks passed
@khaledhosny

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants