Skip to content

Fix get_metric_position_with_fallback to use self #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaledhosny merged 1 commit into from
Jun 2, 2026
Merged

Fix get_metric_position_with_fallback to use self #300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/uharfbuzz/_font.pxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,9 +549,9 @@ cdef class Font:
return position
return None

def get_metric_position_with_fallback(font, tag: OTMetricsTag) -> int:
def get_metric_position_with_fallback(self, tag: OTMetricsTag) -> int:
cdef hb_position_t position
hb_ot_metrics_get_position_with_fallback(font._hb_font, tag, &position)
hb_ot_metrics_get_position_with_fallback(self._hb_font, tag, &position)
return position

def get_metric_variation(self, tag: OTMetricsTag) -> float:
Expand Down
Loading