Skip to content

test: cover FME rollout prompt dual-mode and governance multi-scope CRUD - #827

Closed
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/missing-test-coverage-1b14
Closed

test: cover FME rollout prompt dual-mode and governance multi-scope CRUD#827
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/missing-test-coverage-1b14

Conversation

@cursor

@cursor cursor Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Description

Daily test-coverage automation run targeting recently merged high-risk paths without sufficient regression tests.

Risky behavior now covered

  1. FME feature-flag-rollout prompt (feat: [FME-17249]: FME dual-mode Harness-native scope migration #806) — dual-mode scope validation (workspaceId vs orgId+projectId), rejection of partial scope, and Harness-native NYI caveat for steps that still require legacy mode.
  2. OPA policy/policy_set multi-scope CRUD (feat: allow account and org scope for OPA policies and policy sets #819)resource_scope account/org/project param injection for get, create, update, and delete (list was already covered).

Test files added/updated

  • tests/prompts/feature-flag-rollout.test.ts (new, 7 tests)
  • tests/registry/governance.test.ts (extended, +8 parametrized cases)

Why these tests materially reduce regression risk

  • The rollout prompt is the agent entry point for progressive FME rollouts; a scope-validation regression would send agents down the wrong discovery path or omit the Harness-native limitation caveat.
  • Governance multi-scope support is a recent capability expansion; inconsistent scope param injection on write/read paths would silently target the wrong policy scope (project defaults leaking into account/org operations).

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other — test coverage

Checklist

  • pnpm test passes (69 targeted tests)
  • pnpm typecheck passes
  • pnpm build passes
  • pnpm standards:check passes
  • pnpm docs:check passes
Open in Web View Automation 

Add regression tests for two recently merged high-risk paths:

- feature-flag-rollout prompt: validates workspaceId vs orgId+projectId
  scope selection and ensures Harness-native NYI caveat is surfaced
- policy/policy_set get/create/update/delete: verify resource_scope
  account/org/project param injection matches list behavior (#819)

Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@thisrohangupta

Copy link
Copy Markdown
Collaborator

Closing as superseded by newer follow-ups #842 and #845, which preserve and extend this FME rollout and governance CRUD coverage against current main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants