test: cover FME rollout prompt, governance CRUD scopes, infra deep links - #829
Closed
cursor[bot] wants to merge 1 commit into
Closed
test: cover FME rollout prompt, governance CRUD scopes, infra deep links#829cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add regression tests for recently merged high-risk paths: - feature-flag-rollout prompt: dual-mode scope validation (workspaceId vs orgId+projectId) and Harness-native NYI caveat surfacing (#806) - policy/policy_set get/create/update/delete: verify resource_scope account/org/project param injection matches list behavior (#819) - infrastructure deep links: nested environmentRef aliasing and environment_id param fallback when API omits environmentRef (#809) Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests for three recently merged high-risk code paths that lacked write-operation and prompt-level coverage.
Risky behavior now covered
feature-flag-rolloutmust reject missing/partial scope, interpolateworkspace_idvsorg_id/project_idcorrectly, and surface the Harness-native NYI caveat when appropriate.policyandpolicy_setget/create/update/deletemust inject the sameresource_scopeaccount/org/project query params aslist(previously only list was tested).openInHarnessmust resolveenvironmentIdentifierfrom nestedinfrastructure.environmentRefand from theenvironment_idinput param when the API response omitsenvironmentRef.Test files added/updated
tests/prompts/feature-flag-rollout.test.tstests/registry/governance.test.tstests/registry/infrastructure.test.tsWhy these tests materially reduce regression risk
environmentRefis nested or only present in request params.Type of Change
Checklist
pnpm testpasses (78 targeted tests)pnpm buildpassespnpm typecheckpassespnpm standards:checkpassespnpm docs:checkpasses (no registry changes)Coding Standards
No production code changes — test-only PR.