feat: wire native FME segment update and segment definition keys by ravindraharness · Pull Request #832 · harness/mcp-server

ravindraharness · 2026-08-17T17:49:00Z

Description

Follow-up to #806 for the remaining Harness-native FME segment surface. fme_segment already had list/get/create/delete; this PR adds update and wires membership keys onto fme_segment_definition execute actions. Legacy fme_segment_keys list/update are unchanged. Native org_id+project_id on fme_segment_keys is rejected with a pointer to those execute actions (not a silent NYI).

Dual-mode routing — this PR only

Resource	Legacy (`workspace_id`)	Harness-native (`org_id`+`project_id`)
`fme_segment`	— (Harness-native only, as in #806)	list/get/create/update/delete
`fme_segment_definition`	— (Harness-native only)	list/get/create/update/delete + execute list_keys / add_keys / remove_keys
`fme_segment_keys`	list/update (v2)	rejected — use `fme_segment_definition` execute actions

Native contracts

fme_segment.update — PATCH /fme/api/v4/segments/{name} with Content-Type: application/merge-patch+json. Body: description / tags / owners.
fme_segment.create — wire body matches CreateSegmentRequest (name, trafficType, optional description/tags/owners). Kind is segmentType: STANDARD | LARGE | RULE_BASED (FME_SEGMENT_KINDS; case is canonicalized). If callers pass type, MCP validates locally and omits it on the wire (not a Java field). Native POST uses skipScopeBodyInjection.
Keys — GET/POST .../segment-definitions/{name}/keys and POST .../keys/remove, query environment_id, pagination limit/offset. Empty add_keys only when replace=true.
Delete 400 hasDependents — definition delete fails while membership keys remain. Sequence: remove_keys (or add_keys + replace=true + empty keys) → delete definition → delete segment.

Key implementation changes

src/registry/toolsets/feature-flags.ts plus tests/README.
src/registry/scope-utils.ts — requireHarnessNativeSegmentScope now rejects workspace_id (including mixed with org/project) and does not offer workspace_id as an alternative. No registry/index.ts, types.ts, or prompt changes.
README Feature Flags matrix: fme_segment update; fme_segment_definition execute list_keys, add_keys, remove_keys.

Type of Change

New feature

Checklist

Unit: tests/registry/fme-segment-native-only.test.ts + tests/registry/feature-flags.test.ts
pnpm docs:check (README matrix matches registry)

Coding Standards (registry-driven MCP model)

No new server.registerTool() calls
Existing feature-flags toolset extended
operationPolicy on every new/changed endpoint
Shared response extractors
identifierFields and scope declared
No console.log() in src/

Test plan

Unit: native update merge-patch; keys list/add/remove; workspace_id rejected on native-only ops
Live QA: create → update → definition create → add/list/remove keys → delete definition → delete segment

Native segment PATCH and definition key execute actions were the remaining v4 gaps after harness#806; point native fme_segment_keys callers at those actions instead of advertising a fake NYI native keys resource. Co-authored-by: Cursor <cursoragent@cursor.com>

Harness NG orgIdentifier/projectIdentifier injection made v4 create and key-mutation JSON fail validation. Co-authored-by: Cursor <cursoragent@cursor.com>

CLAassistant · 2026-08-17T17:49:18Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ cursoragent
❌ ravindraharness
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

CreateSegmentRequest has no type field, and Jackson rejects unknown JSON. Keep local type validation when callers pass it. Co-authored-by: Cursor <cursoragent@cursor.com>

Reviewers would see describe() still requiring type after the wire omit, and add_keys allowed empty keys without replace=true. README matrix now matches the new update and key execute actions so docs:check passes. Co-authored-by: Cursor <cursoragent@cursor.com>

Java now requires segment_type on list and segmentType on create; omitting kind or sending JSON type 400s. Co-authored-by: Cursor <cursoragent@cursor.com>

Keep deprecated standard/rule-based segments native-rejected and segment_keys as not-yet-implemented, matching the first dual-mode PR. New fme_segment ops stay org/project-only and reject workspace_id. Co-authored-by: Cursor <cursoragent@cursor.com>

List already rewrote standard to STANDARD; create exact-matched uppercase only, so the same agent input 400ed on POST.

Remove the added Harness-native key management note from the fme_segment_keys resource description for now. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>

puthrayaharness · 2026-08-20T21:26:46Z

          responseExtractor: passthrough,
-          description: "Delete a segment by name.",
+          description:
+            "Delete a segment by name. MCP does not gate on kind; the backend STANDARD-store lookup 404s for LARGE/RULE_BASED names. Returns 400 hasDependents if any environment definition or flag still references it — delete definitions (after clearing keys) first.",


Uncessary statement -

MCP does not gate on kind;

cursor · 2026-08-20T22:10:29Z

          responseExtractor: passthrough,
-          description: "Delete a segment by name.",
+          description:
+            "Delete a segment by name. MCP does not gate on kind; the backend STANDARD-store lookup 404s for LARGE/RULE_BASED names. Returns 400 hasDependents if any environment definition or flag still references it — delete definitions (after clearing keys) first.",


Removed the unnecessary "MCP does not gate on kind;" clause from the fme_segment delete description in commit a6a2a36. The description still notes the backend STANDARD-store lookup behavior and the hasDependents dependency ordering.

puthrayaharness · 2026-08-20T22:19:51Z

@cursor Review this PR in detail and align with the rest of the recent changes. Resolve merge conflicts
Also merge these changes into this PR - #833

Update the PR title/description post merge.

cursor · 2026-08-20T22:19:54Z

Skipping Bugbot: Bugbot could not find a matching SCM installation for this repository. Please reinstall the GitHub/GitLab installation and/or remove the installation from non-Bugbot accounts. Visit the Bugbot dashboard to update your settings.

ravindraharness and others added 2 commits August 17, 2026 23:12

fix: skip NG scope fields on native FME segment POST bodies

6543b16

Harness NG orgIdentifier/projectIdentifier injection made v4 create and key-mutation JSON fail validation. Co-authored-by: Cursor <cursoragent@cursor.com>

ravindraharness and others added 5 commits August 17, 2026 23:27

fix: omit type from native FME segment create bodies

5b8fd9a

CreateSegmentRequest has no type field, and Jackson rejects unknown JSON. Keep local type validation when callers pass it. Co-authored-by: Cursor <cursoragent@cursor.com>

fix: align fme_segment list and create with public v4 kinds

602286c

Java now requires segment_type on list and segmentType on create; omitting kind or sending JSON type 400s. Co-authored-by: Cursor <cursoragent@cursor.com>

fix: canonicalize create segmentType and reuse FME_SEGMENT_KINDS

a46ef65

List already rewrote standard to STANDARD; create exact-matched uppercase only, so the same agent input 400ed on POST.

ravindraharness marked this pull request as ready for review August 20, 2026 14:38

puthrayaharness requested changes Aug 20, 2026

View reviewed changes

Comment thread src/registry/toolsets/feature-flags.ts Outdated

Revert fme_segment_keys description extension per review

fbfde3d

Remove the added Harness-native key management note from the fme_segment_keys resource description for now. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>

puthrayaharness requested changes Aug 20, 2026

View reviewed changes

cursor Bot reviewed Aug 20, 2026

View reviewed changes

puthrayaharness mentioned this pull request Aug 20, 2026

feat: add native-only FME environment get, create, update, and delete #833

Open

11 tasks

Navigation Menu

Uh oh!

feat: wire native FME segment update and segment definition keys - #832

feat: wire native FME segment update and segment definition keys#832
ravindraharness wants to merge 8 commits into
harness:mainfrom
ravindraharness:fme-v4-remaining-segment

ravindraharness commented Aug 17, 2026 •

edited

Loading

Uh oh!

CLAassistant commented Aug 17, 2026 •

edited

Loading

Uh oh!

Uh oh!

puthrayaharness Aug 20, 2026

Uh oh!

cursor Bot Aug 20, 2026

Uh oh!

puthrayaharness commented Aug 20, 2026

Uh oh!

cursor Bot commented Aug 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

ravindraharness commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dual-mode routing — this PR only

Native contracts

Key implementation changes

Type of Change

Checklist

Coding Standards (registry-driven MCP model)

Test plan

Uh oh!

CLAassistant commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

puthrayaharness Aug 20, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot Aug 20, 2026

Choose a reason for hiding this comment

Uh oh!

puthrayaharness commented Aug 20, 2026

Uh oh!

cursor Bot commented Aug 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ravindraharness commented Aug 17, 2026 •

edited

Loading

CLAassistant commented Aug 17, 2026 •

edited

Loading