test: cover release-management dispatch, rollout prompt, and IaCM provider guards - #849
Draft
cursor[bot] wants to merge 1 commit into
Draft
test: cover release-management dispatch, rollout prompt, and IaCM provider guards#849cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…vider guards Add regression tests for recently merged high-risk paths: - Release Management registry dispatch (RMG gateway, header scoping, scope body) - RMG path-builder guards and list/activity extractor edge cases - feature-flag-rollout prompt scope validation and native-mode caveat - IaCM provider create/update preflight rejection before API calls Fix feature-flag-rollout prompt to append the nativeModeCaveat that was defined but never included in the rendered prompt text. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests for recently merged high-risk paths that lacked dispatch-level or prompt-level coverage.
Risky behavior now covered
registry.dispatchforreleaselist,release_processcreate, andrelease_execution_phaselist: RMG gateway base URL, header-based scoping (noaccountIdentifierleak), and scope-in-body POST semanticsrequireReleaseAndPhaseguards reject missingrelease_id,phase_identifier, andactivity_identifierbefore malformed URLs are builtreleaseStatusfield alias, raw array payloads, empty scopes body, default activity sort, task limit clamping, Spring pagination metadatafme_rollout_statuscaveattype,id, andversionbefore API callsTest files added/updated
tests/prompts/feature-flag-rollout.test.ts(new)tests/registry/toolsets/release-management.test.tstests/registry/iacm.test.tsWhy these tests materially reduce regression risk
Release Management is default-on with header-scoped routing and body-carried scope — metadata-only tests missed dispatch wiring bugs that would silently hit the wrong gateway or leak scope params. The rollout prompt drives multi-step FME agent workflows; without tests, dual-mode scope migration could ship broken guidance. IaCM provider version writes are medium-risk infra mutations where missing-field errors must fail before network calls.
Small production fix
Append
nativeModeCaveatto the feature-flag-rollout prompt text — the variable was defined in #806 but never included in the rendered message.Type of Change
Checklist
pnpm testpassespnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpasses (no registry/tool count changes)