test: add FME extractor and feature-flag-rollout prompt coverage - #853
Draft
cursor[bot] wants to merge 1 commit into
Draft
test: add FME extractor and feature-flag-rollout prompt coverage#853cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Cover flattenTrafficType, fmeV4PaginatedListExtract, and deep-link trafficTypeId projection added in recent FME native-mode work (#806, #831, #838). Add prompt tests to guard against stale native-mode caveats after fme_rollout_status was wired. Harden MCPB release metadata validation edge cases from #846. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds targeted regression tests for recently merged FME native-mode work and MCPB release metadata validation.
Risky behavior now covered
flattenTrafficType/fmeListExtract/fmeGetExtract— FME feature-flag responses nesttrafficType.id; flattening totrafficTypeIdis required foropenInHarnessdeep links (/targets/{trafficTypeId}/splits/{id}). A regression here silently breaks Harness UI links on list/get.fmeV4PaginatedListExtract— Native v4 list APIs return{ data, totalCount }; the extractor promotes these to{ items, total }soharness_listpagination stays correct. Tests cover the happy path and non-array passthrough.feature-flag-rolloutprompt — Recent commits (feat: wire native FME feature flag definition list, delete, and execute #831, feat: wire native FME traffic type and rollout status lists #838) removed stale native-mode caveats afterfme_rollout_statusand flag-definition execute actions were wired. Prompt tests lock in correct scope args and guard against reintroducing "not yet implemented" warnings.assetNameForVersionandnormalizeBundleManifestnow reject invalid versions and manifest/package mismatches (Publish versioned MCPB release assets #846).Test files added/updated
tests/registry/fme-extractors.test.ts(new)tests/prompts/feature-flag-rollout.test.ts(new)tests/release-metadata.test.ts(updated)Why these tests materially reduce regression risk
FME dual-mode migration (#806–#838) touched shared extractors and prompt guidance that agents rely on for rollout workflows. The extractors had dispatch-level pagination tests but no unit coverage for
trafficTypeIdflattening or deep-link URL construction — the highest-impact gap for user-facing links. Prompt tests prevent stale caveats from misleading agents after native APIs land.Type of Change
Checklist
pnpm testpasses (targeted: 28 tests in 3 files)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpasses (registry/tool counts unchanged)