test: cover FME rollout prompt and schema sync reuse field - #855
Draft
cursor[bot] wants to merge 1 commit into
Draft
test: cover FME rollout prompt and schema sync reuse field#855cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add regression tests for recent FME native-scope prompt changes: - dual-mode scope validation (workspace_id vs org_id+project_id) - rollout workflow resource references without stale native-mode caveats Lock in schema sync #823 DBApplySchemaStepInfo reuse field contract. Remove dead nativeModeCaveat code left after rollout status shipped. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests for recently merged FME native-scope rollout prompt changes and schema sync #823.
Risky behavior now covered
feature-flag-rolloutprompt (PRs feat: wire native FME feature flag definition list, delete, and execute #831, feat: wire native FME traffic type and rollout status lists #838): dual-mode scope validation (workspace_idvsorg_id+project_id), correct interpolation of scope args into rollout instructions, and workflow references tofme_feature_flag_definition/fme_rollout_statuswithout stale native-mode caveats that would mislead agents after rollout status shipped.DBApplySchemaStepInfo.reusefield contract in v0 pipeline/template bundles.Test files added/updated
tests/prompts/feature-flag-rollout.test.ts(new)tests/schemas/schema-bundle-contract.test.ts(updated)Why these tests materially reduce regression risk
Agents rely on MCP prompts for multi-step FME rollout workflows. A stale caveat or missing scope validation would cause failed rollouts or wrong API paths. The schema contract test prevents silent loss of the
reusefield on DB schema apply steps during upstream sync.Production cleanup
Removed dead
nativeModeCaveatvariable left insrc/prompts/feature-flag-rollout.tsafter PR #838 removed its usage.Type of Change
Checklist
pnpm testpasses (24 targeted tests)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpasses (registry/tool counts unchanged)