[fix] stabilize windows bazel smoke for harper-ui#344
Draft
bniladridas wants to merge 1 commit intomainfrom
Draft
[fix] stabilize windows bazel smoke for harper-ui#344bniladridas wants to merge 1 commit intomainfrom
bniladridas wants to merge 1 commit intomainfrom
Conversation
harper-main-hq
previously approved these changes
Apr 29, 2026
135583c to
d51fbb9
Compare
b3b4869 to
1fc9480
Compare
1fc9480 to
92716d5
Compare
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
lib/harper-ui/BUILDto use explicit Rust crate deps forharper_ui,harper, andharper_batchinstead of relying on ambiguous crate-universe helper expansion.aliases(...)for theharper-uiworkspace member so Bazel still emits the expected crate-name mapping.crate_rootwiring for the UI library and binaries..github/workflows/build-bazel.ymlWindows smoke diagnostics by enabling--verbose_failures -s, keying theharper_uiparams dump off the actual Bazel build-step outcome, preserving the build failure instead of masking it behind later smoke steps, checking whether each--externartifact and-Ldependencypath from the dumped params file actually exists on the runner, and running a directrustcsmoke compile against one dumped extern to distinguish artifact-presence problems from rustc-loading problems.bazel runstep with direct execution of the builtharper.exe --versionbinary by resolving the file frombazel cqueryrelative to Bazel's execution root and invoking it viaStart-Process, avoiding Windows argument-forwarding, path-resolution, and shell-quoting issues.docs/development/bazel-windows-debugging.mdas the Windows Bazel smoke troubleshooting cookbook and linked it from.github/workflows/README.md.rustc.exe @response-filecompile with onlyserdestill fails withE0463even when the dumped extern artifact and dependency paths all exist..github/workflows/README.mdso the Bazel CI entry matches the current Windows smoke lane behavior.lib/harper-ui/BUILDomission.Validation
cargo check -p harper-ui/bin/zsh -lc 'bazel shutdown >/dev/null 2>&1 || true; CARGO_BAZEL_REPIN=1 bazel build :harper_bin'check yamlfmtclippycargo check