Update the node removal with one known issue - #1108
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Harvester documentation for host/node removal to better explain an intermittent “node stuck draining” issue and provide a concrete workaround, improving operator guidance during cluster maintenance.
Changes:
- Adds a safety warning before running
rke2-uninstall.sh(target node only, no confirmation prompt). - Expands the node removal steps and documents a known issue where removal can get stuck in a draining loop.
- Documents a workaround leveraging the
fleet.cattle.io/agentlabel to steerfleet-agentscheduling away from the draining node.
Suppressed comments (2)
docs/host/host.md:183
- “re-schedule” is inconsistent with other docs in this repo (which use “reschedule/rescheduled”). Also, using passive voice here reads more naturally.
In the backend, `fleet-agent` pods continuously re-schedule onto the node, triggering an endless Terminating loop that halts node removal.
docs/host/host.md:194
- This sentence mixes a modal verb (“might”) with a conjugated verb (“re-deploys”). It should use the base form, and “redeploy” is also the spelling used elsewhere in these docs.
During node removal the cluster topology changes, and it triggers the `fleet-controller` to roll out new revisions of the `fleet-agent` deployment. Because `fleet-agent` carries broad tolerations (`node.kubernetes.io/unreachable:NoSchedule`, `node.kubernetes.io/unschedulable:NoSchedule` and more), `kube-scheduler` might continue to select the draining node as a valid target and re-deploys agent pods onto it.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
w13915984028
force-pushed
the
doc11349
branch
4 times, most recently
from
August 19, 2026 13:31
1908fa8 to
63f6e7d
Compare
Signed-off-by: Jian Wang <jian.wang@suse.com>
This was referenced Aug 19, 2026
Member
Author
|
PR is ready for review, thanks. There is cross refer between this PR and KB harvester/harvesterhci.io#114; document will be updated further to ref the KB after KB is published. |
jillian-maroket
previously approved these changes
Aug 20, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
1 task
jillian-maroket
previously approved these changes
Aug 20, 2026
Contributor
There was a problem hiding this comment.
Ok except for the duplicated sentence. See comment.
Signed-off-by: Jian Wang <jian.wang@suse.com>
jillian-maroket
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Node removal is not always smooth on Harvester.
Solution:
Update the document about the known issue and workaround.
Related Issue(s):
harvester/harvester#11349
Test plan:
Additional documentation or context