Change version to harvester docs links to "latest" im harvester_secur… - #104
Open
cybit wants to merge 1 commit into
Open
Change version to harvester docs links to "latest" im harvester_secur…#104cybit wants to merge 1 commit into
cybit wants to merge 1 commit into
Conversation
…ity_best_practice.md Links to https://docs.harvesterhci.io/ point to https://docs.harvesterhci.io/v1.2/ (which no longer exists). Moved this to https://docs.harvesterhci.io/latest/ which should redirect to latest (or at least a working) version. Signed-off-by: Cyril Bitterich <cebit-github@gunnet.de>
✅ Deploy Preview for harvester-home-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Links to https://docs.harvesterhci.io/ in harvester_security_best_practices point to https://docs.harvesterhci.io/v1.2/ . This path no longer exists. The oldest available one is v1.4 .
Readers will be sent to an empty page when they click on the page. When manually changing the version using the dropdown field a working page can be found. But this is not intuitive.
Solution:
Replacing "v1.2" with "v1.7" or "latest" sends readers to a working page.
Using "latest" should prevent the fix to "fail" until the target page actually gets (re-)moved.
Related Issue(s):
Issue harvester/harvester#10318
Test plan:
I did manually click through after commit. I could not figure out how to trigger an automated test system.
Additional documentation or context
/latest/ currently points to v1.6 instead of v1.7 (harvester/harvester#10317) . But at least the target page will be available and usable.