change ipxe scripts to generate static address based templates by ibrokethecloud · Pull Request #85 · harvester/seeder

ibrokethecloud · 2026-03-20T06:51:35Z

change ipxe script to generate static address to work around dracut / networkmanager issues when network may have multiple dhcp servers

Problem:

Solution:

change ipxe script to generate static address to work around dracut / networkmanager issues when network may have multiple dhcp servers

Related Issue(s):

harvester/harvester#10258

Test plan:

Additional documentation or context

… networkmanager issues when network may have multiple dhcp servers Signed-off-by: Gaurav Mehta <gaurav.mehta@suse.com>

Copilot

Pull request overview

Updates Harvester seeder’s Tinkerbell iPXE generation to boot with a static network configuration (instead of relying on DHCP during initramfs), to mitigate dracut/NetworkManager issues in environments with multiple DHCP servers.

Changes:

Extend generateIPXEScript to accept IP/netmask/gateway and render a static ip=...:off kernel cmdline.
Always set a persistent ifname=netboot:<mac> mapping via AfterInstallChrootCommands in generated cloud-config.
Update the existing unit test call site for the new generateIPXEScript signature.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
pkg/tink/tink.go	Pass static network params into iPXE template; adjust cloud-config post-install grubenv cmdline behavior.
pkg/tink/tink_test.go	Update test invocation for the new iPXE generator signature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-20T06:54:49Z

 iflinkwait -t 5000
-kernel ${base}/harvester-${version}-vmlinuz-${arch} initrd=harvester-${version}-initrd-${arch} ip=dhcp net.ifnames=1 rd.cos.disable rd.noverifyssl BOOTIF={{ .MacAddress }} root=live:${base}/harvester-${version}-rootfs-${arch}.squashfs console=tty1 harvester.install.automatic=true boot_cmd='echo include_ping_test=yes >> /etc/conf.d/net-online' harvester.install.config_url={{ .HegelEndpoint }} {{if gt .VlanID 1}}ifname=netboot:{{ .MacAddress }}  vlan=vlan{{ .VlanID }}:netboot {{end}}
+kernel ${base}/harvester-${version}-vmlinuz-${arch} initrd=harvester-${version}-initrd-${arch} ip={{ .IP }}::{{ .Gateway }}:{{ .Netmask }}::netboot:off net.ifnames=1 rd.cos.disable rd.noverifyssl BOOTIF={{ .MacAddress }} ifname=netboot:{{ .MacAddress }} root=live:${base}/harvester-${version}-rootfs-${arch}.squashfs console=tty1 harvester.install.automatic=true boot_cmd='echo include_ping_test=yes >> /etc/conf.d/net-online' harvester.install.config_url={{ .HegelEndpoint }} {{if gt .VlanID 1}}vlan=vlan{{ .VlanID }}:netboot {{end}}
 initrd ${base}/harvester-${version}-initrd-${arch}


generateIPXEScript now requires IP/netmask/gateway and always emits a static ip=...:off kernel parameter. If any of these fields are empty (e.g. unexpected inventory status/pool status), the generated kernel cmdline will be malformed and can break provisioning. Consider validating these inputs and falling back to the previous ip=dhcp behavior when they are not all set.

Copilot · 2026-03-20T06:54:49Z

+	_, err := generateIPXEScript("v1.1.3", "http://imagestore/iso", "hegelEndpoint", "ab:cd:ef:gh:ij", "amd64", 1, "192.168.1.101", "255.255.255.0", "192.168.1.1")
 	assert.NoError(err, "expect no error during generation of ipxe script")


The unit test only asserts that generateIPXEScript returns no error, but it doesn’t verify the new behavior (static addressing params and ifname=netboot mapping) in the generated script. Adding assertions for the rendered kernel line would prevent regressions in the new workaround logic.

Suggested change

_, err := generateIPXEScript("v1.1.3", "http://imagestore/iso", "hegelEndpoint", "ab:cd:ef:gh:ij", "amd64", 1, "192.168.1.101", "255.255.255.0", "192.168.1.1")

assert.NoError(err, "expect no error during generation of ipxe script")

script, err := generateIPXEScript("v1.1.3", "http://imagestore/iso", "hegelEndpoint", "ab:cd:ef:gh:ij", "amd64", 1, "192.168.1.101", "255.255.255.0", "192.168.1.1")

assert.NoError(err, "expect no error during generation of ipxe script")

assert.Contains(script, "ifname=netboot", "expected kernel params to include ifname=netboot mapping")

assert.Contains(script, "192.168.1.101", "expected kernel params to include static IP address")

assert.Contains(script, "255.255.255.0", "expected kernel params to include subnet mask")

assert.Contains(script, "192.168.1.1", "expected kernel params to include gateway")

Copilot · 2026-03-20T06:54:49Z

 // and uses the same for create / join of node
-func generateIPXEScript(harvesterVersion, isoURL, hegelEndpoint, macAddress, arch string, vlanID int) (string, error) {
+func generateIPXEScript(harvesterVersion, isoURL, hegelEndpoint, macAddress, arch string, vlanID int, ip string, netmask string, gateway string) (string, error) {



The generateIPXEScript signature has grown to include multiple network parameters, making call sites harder to read and easier to misuse (argument order bugs). Consider passing a small struct (e.g. a network config object) or reusing an existing network type to group ip/netmask/gateway together.

starbops

LGTM, thanks.

ibrokethecloud · 2026-03-22T22:58:31Z

@mergify backport v1.8

mergify · 2026-03-22T22:58:39Z

backport v1.8

✅ Backports have been created

Details

#86 change ipxe scripts to generate static address based templates (backport #85) has been created for branch v1.8

mergify · 2026-08-21T03:11:55Z

backport v1.8

✅ Backports have been created

Details

#183 change ipxe scripts to generate static address based templates (backport #85) has been created for branch v1.8 but encountered conflicts

Cherry-pick of a4b0884 has failed:

On branch mergify/bp/v1.8/pr-85
Your branch is up to date with 'origin/v1.8'.

You are currently cherry-picking commit a4b0884.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   pkg/tink/tink.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

change ipxe script to generate static address to work around dracut /…

ab5d586

… networkmanager issues when network may have multiple dhcp servers Signed-off-by: Gaurav Mehta <gaurav.mehta@suse.com>

Copilot AI review requested due to automatic review settings March 20, 2026 06:51

Copilot started reviewing on behalf of ibrokethecloud March 20, 2026 06:52 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

ibrokethecloud requested a review from starbops March 20, 2026 07:19

starbops approved these changes Mar 20, 2026

View reviewed changes

ibrokethecloud merged commit a4b0884 into harvester:main Mar 22, 2026
8 checks passed

mergify Bot mentioned this pull request Mar 22, 2026

change ipxe scripts to generate static address based templates (backport #85) #86

Merged

mergify Bot mentioned this pull request Aug 21, 2026

change ipxe scripts to generate static address based templates (backport #85) #183

Closed

Navigation Menu

Uh oh!

change ipxe scripts to generate static address based templates - #85

change ipxe scripts to generate static address based templates#85
ibrokethecloud merged 1 commit into
harvester:mainfrom
ibrokethecloud:static-address-ipxe-script

ibrokethecloud commented Mar 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Uh oh!

starbops left a comment

Uh oh!

Uh oh!

ibrokethecloud commented Mar 22, 2026

Uh oh!

mergify Bot commented Mar 22, 2026 •

edited

Loading

Uh oh!

mergify Bot commented Aug 21, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		_, err := generateIPXEScript("v1.1.3", "http://imagestore/iso", "hegelEndpoint", "ab:cd:ef:gh:ij", "amd64", 1, "192.168.1.101", "255.255.255.0", "192.168.1.1")
		assert.NoError(err, "expect no error during generation of ipxe script")

-	_, err := generateIPXEScript("v1.1.3", "http://imagestore/iso", "hegelEndpoint", "ab:cd:ef:gh:ij", "amd64", 1, "192.168.1.101", "255.255.255.0", "192.168.1.1")
-	assert.NoError(err, "expect no error during generation of ipxe script")
+	script, err := generateIPXEScript("v1.1.3", "http://imagestore/iso", "hegelEndpoint", "ab:cd:ef:gh:ij", "amd64", 1, "192.168.1.101", "255.255.255.0", "192.168.1.1")
+	assert.NoError(err, "expect no error during generation of ipxe script")
+	assert.Contains(script, "ifname=netboot", "expected kernel params to include ifname=netboot mapping")
+	assert.Contains(script, "192.168.1.101", "expected kernel params to include static IP address")
+	assert.Contains(script, "255.255.255.0", "expected kernel params to include subnet mask")
+	assert.Contains(script, "192.168.1.1", "expected kernel params to include gateway")

Uh oh!

Conversation

ibrokethecloud commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem:

Solution:

Related Issue(s):

Test plan:

Additional documentation or context

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

starbops left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ibrokethecloud commented Mar 22, 2026

Uh oh!

mergify Bot commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

mergify Bot commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ibrokethecloud commented Mar 20, 2026 •

edited

Loading

mergify Bot commented Mar 22, 2026 •

edited

Loading

mergify Bot commented Aug 21, 2026 •

edited

Loading