fix: find 034#1066
Open
AlbertoMolinaIoBuilders wants to merge 5 commits intodevelopmentfrom
Open
Conversation
Signed-off-by: Alberto Molina <alberto@io.builders>
Signed-off-by: Alberto Molina <alberto@io.builders>
…D-1502-FIND-034 Signed-off-by: Alberto Molina <alberto@io.builders>
marcosio
requested changes
May 6, 2026
Signed-off-by: Alberto Molina <alberto@io.builders>
…D-1502-FIND-034 Signed-off-by: Alberto Molina <alberto@io.builders>
marcosio
requested changes
May 7, 2026
| function nominalValueAtSnapshot(uint256 _snapshotID) external view returns (uint256 nominalValue_); | ||
|
|
||
| function nominalValueDecimalsAtSnapshot(uint256 _snapshotID) external view returns (uint8 nominalValueDecimals_); | ||
| } |
| ) external view override returns (uint8 nominalValueDecimals_) { | ||
| nominalValueDecimals_ = SnapshotsStorageWrapper.nominalValueDecimalsAtSnapshot(_snapshotID); | ||
| } | ||
| } |
| unchecked { | ||
| staticInterfaceIds_[--selectorIndex] = type(INominalValueAtSnapshot).interfaceId; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Just build the two arrays as normal, without index.
marcosio
requested changes
May 7, 2026
Contributor
marcosio
left a comment
marcosio
left a comment
There was a problem hiding this comment.
Just alignment with latest commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Testing
Node version:
Checklist