chore(IAsset): integrate migration tip — doc search bar + amortization SDK + CI cache fix#959
Closed
MiguelLZPF wants to merge 5 commits intorefactor/BBND-1458-IAssetfrom
Closed
Conversation
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
…ould not be used Signed-off-by: mamoralesiob <miguelangel@io.builders>
… fix into IAsset Signed-off-by: Miguel_LZPF <miguel.carpena@io.builders>
Per-feature changesets describe work that has already been merged into this integration branch via the IAsset + migration parents. They will be regenerated consolidated at release time via npm run changeset:version. Keeping config.json and README.md. Signed-off-by: Miguel_LZPF <miguel.carpena@io.builders>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings
refactor/BBND-1458-IAssetup torefactor/BBND-1458-59-60-lib-diamond-migrationHEAD so every feature present onorigin/developmentis available here as well. This closes the gap analysis documented in.temp/iasset-integration-decisions.md.What this branch adds
5968e9f05doc search bar (originallyea1e226d2on development)370321974amortization SDK (originally4431f2e56on development)6f10d3601CI cache fix (migration-only)Decisions (code-verified, not trusted from commit messages)
c7d474497deployProxygeneric overload: SKIP — byte-identical implementation already on IAsset (independently re-introduced during migration work).777e27264redundant-code cleanup: SKIP — target filesERC1410BasicStorageWrapperRead.solandAdjustBalancesStorageWrapper2.solno longer exist on IAsset under those paths (lib-diamond restructuring superseded them).2b68e6c1cHWC update: FALSE POSITIVE — all three branches already share the same@walletconnect/*versions.f3f285356release v6.0.0 bump: SKIP — regenerates at release time.Verification
npx hardhat compile— cleannpm run ats:contracts:lint— clean (natspec warnings only)npm run ats:contracts:build— clean (registry regenerated)npm run ats:sdk:build— clean (0 TypeScript errors)npm run ats:web:build— built in 39.5snpx hardhat test— 1386 passing, 0 failing (56s)origin/refactor/BBND-1458-IAssetororigin/refactor/BBND-1458-59-60-lib-diamond-migration). No hand-written code introduced.Next step after merge
Fast-forward
refactor/BBND-1458-59-60-lib-diamond-migrationto this branch's HEAD so migration becomes the canonical "new development" target.Test plan
apps/docs/docusaurus.config.tscontains@easyops-cn/docusaurus-search-localpackages/ats/sdk/src/port/in/security/amortization/Amortization.tsexists