fix: 6017 link manually-selected tool on policy/tool import#6018
Open
fix: 6017 link manually-selected tool on policy/tool import#6018
Conversation
Resolve the user-picked tool from the local DB instead of round-tripping through importSubTools, which silently failed and left policy.config and schema $defs pointing at the foreign tool. Signed-off-by: Alex Piatakov <alex.piatakov@swirldslabs.com>
Apply the same override-resolution to importToolByFile, and refresh tool.tools after replaceConfig so nested-tool schemas are populated in the local DB. Signed-off-by: Alex Piatakov <alex.piatakov@swirldslabs.com>
Both policy- and tool-import paths share the same override-resolution path. Signed-off-by: Alex Piatakov <alex.piatakov@swirldslabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When importing a policy or tool, if a nested tool is not found by message ID the user can manually select a local equivalent via the import dialog. Previously the override was ignored, the policy config and schema references still pointed at the foreign tool, causing import errors and Validate failures.
messageIdandhashin policy config to point at the locally-selected tool$defsIRIs to reference the local tool's schemasresolveToolOverrideshelper used by both policy-import and tool-import pathsupdateToolConfigafter config rewrite so nested tool descriptors reflect updated referencesRelated issue(s)
Fixes #6017
Checklist