generator-go-sdk - Generate date functions from ancestors#5391
Open
QixiaLu wants to merge 2 commits into
Open
Conversation
wuxu92
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Description
This PR fixes date functions for multi-level discriminated types:
codeForDateFunctionsusedc.model.ParentTypeName(immediate parent) to find DateTime fields, whilestructLinesForModelusesfindModelAncestry()to determine which ancestor fields to include on the struct. In 3+ level discriminated hierarchies, this mismatch causes compile errors when an intermediate parent has DateTime fields that aren't on the structPR Checklist
Changes to Tooling
Testing Command(s) Used:
# e.g., go test ./tools/generator-go-sdk/...Testing Evidence:
Relevant successful SDK builds:
https://github.com/hashicorp/pandora/actions/runs/25717383360/job/75510290144
https://github.com/hashicorp/pandora/actions/runs/25717383334/job/75510290097
https://github.com/hashicorp/pandora/actions/runs/25717383350/job/75510290055
Previous problematic Data Plane SDK builds succeeds now:

Related Issue(s)
Fixes #5369
AI Assistance Disclosure
Note
If this PR changes meaningfully during the course of review, please update the title and description as required.