Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
// Copyright IBM Corp. 2023, 2026
// SPDX-License-Identifier: MPL-2.0

package dataworkarounds

import (
"errors"

sdkModels "github.com/hashicorp/pandora/tools/data-api-sdk/v1/models"
)

var _ workaround = workaroundWeb40128{}

type workaroundWeb40128 struct{}

func (workaroundWeb40128) IsApplicable(serviceName string, apiVersion sdkModels.APIVersion) bool {
if serviceName != "Web" {
return false
}

switch apiVersion.APIVersion {
case "2023-01-01", "2023-12-01", "2024-11-01", "2025-05-01":
return true
}

return false
}

func (workaroundWeb40128) Name() string {
return "Web / 40128"
}

func (workaroundWeb40128) Process(input sdkModels.APIVersion) (*sdkModels.APIVersion, error) {
resource, ok := input.Resources["WebApps"]
if !ok {
return nil, errors.New("expected a resource named `WebApps` but didn't get one")
}

model, ok := resource.Models["AzureStorageInfoValue"]
if !ok {
return nil, errors.New("expected a model named `AzureStorageInfoValue` but didn't get one")
}

if _, ok := model.Fields["Endpoint"]; ok {
return nil, errors.New("found a field named `Endpoint` but expected none, this workaround can be removed")
}

model.Fields["Endpoint"] = sdkModels.SDKField{
JsonName: "endpoint",
ObjectDefinition: sdkModels.SDKObjectDefinition{
Type: sdkModels.StringSDKObjectDefinitionType,
},
Optional: true,
}
resource.Models["AzureStorageInfoValue"] = model
input.Resources["WebApps"] = resource

return &input, nil
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
// Copyright IBM Corp. 2023, 2026
// SPDX-License-Identifier: MPL-2.0

package dataworkarounds

import (
"testing"

sdkModels "github.com/hashicorp/pandora/tools/data-api-sdk/v1/models"
)

func TestWorkaroundWeb40128(t *testing.T) {
versions := []string{"2023-01-01", "2023-12-01", "2024-11-01", "2025-05-01"}

for _, version := range versions {
t.Run(version, func(t *testing.T) {
input := sdkModels.APIVersion{
APIVersion: version,
Resources: map[string]sdkModels.APIResource{
"WebApps": {
Models: map[string]sdkModels.SDKModel{
"AzureStorageInfoValue": {
Fields: map[string]sdkModels.SDKField{},
},
},
},
},
}

workaround := workaroundWeb40128{}
if !workaround.IsApplicable("Web", input) {
t.Fatalf("expected workaround to apply to Web %q", version)
}

result, err := workaround.Process(input)
if err != nil {
t.Fatalf("processing workaround: %+v", err)
}

field := result.Resources["WebApps"].Models["AzureStorageInfoValue"].Fields["Endpoint"]
if field.JsonName != "endpoint" {
t.Errorf("expected JsonName to be %q, got %q", "endpoint", field.JsonName)
}
if !field.Optional {
t.Error("expected Endpoint to be optional")
}
if field.ObjectDefinition.Type != sdkModels.StringSDKObjectDefinitionType {
t.Errorf("expected Endpoint to be a string, got %q", field.ObjectDefinition.Type)
}
})
}
}

func TestWorkaroundWeb40128IsNotApplicable(t *testing.T) {
workaround := workaroundWeb40128{}

for _, test := range []struct {
service string
version string
}{
{service: "Compute", version: "2023-12-01"},
{service: "Web", version: "2016-06-01"},
} {
if workaround.IsApplicable(test.service, sdkModels.APIVersion{APIVersion: test.version}) {
t.Errorf("expected workaround not to apply to %s %s", test.service, test.version)
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ var workarounds = []workaround{
workaroundSubscriptions20254{},
workaroundWeb14529{},
workaroundWeb31682{},
workaroundWeb40128{},
WorkaroundWeb43978{},

// Special Case for Network duplicated Enum
Expand Down
Loading