`azurerm_logic_app_standard` - fix issue when updating an app with file share mount by ziyeqf · Pull Request #31668 · hashicorp/terraform-provider-azurerm

ziyeqf · 2026-02-04T02:26:34Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The endpoint is required for file share mount, however the property is not exposed on rest api spec. remove it from the update payload to avoid override.
rest api side issue: Azure/azure-rest-api-specs#40128

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

the failed one shall be not related to this change.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_logic_app_standard - remove Azurestorageaccount from update payload [GH-00000]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #31606

AI Assistance Disclosure

AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

payload

teowa

Thanks @ziyeqf , LGTM!

gerrytan

Thx @ziyeqf , please add an acctest case that reproduce the mentioned issue (storage account with account_kind "FileStorage")

…MountUpdate` test case

ziyeqf · 2026-03-16T23:22:15Z

test over latest change: https://hashicorp.teamcity.com/buildConfiguration/TF_AzureRM_AZURERM_SERVICE_PUBLIC_LOGIC/630958

gerrytan

Thx for adding the acctest @ziyeqf . There's still acctest failure, but this PR looks good otherwise.

gerrytan · 2026-03-16T23:57:56Z

+  storage_account_access_key = azurerm_storage_account.test.primary_access_key
+}
+
+resource "azapi_resource_action" "logicapp_storage_config" {


The acctest failed here because you haven't configured azapi provider block

updated, but tbh I'm a bit concerned invovling azapi provider in the test

ziyeqf · 2026-03-17T22:50:16Z

github-actions · 2026-05-18T07:14:12Z

This draft pull request is being closed because it has been inactive for 60 days ⏳. This helps our maintainers find and focus on the active contributions.

If you would like to continue working on this, please reopen the pull request and mark it as ready for review when complete. Thank you!

katbyte · 2026-07-07T14:43:46Z

+		"azapi": {
+			VersionConstraint: "=2.8.0",
+			Source:            "azure/azapi",
+		},


can we please remove this? we should not be adding tests involving azAPI

katbyte · 2026-07-07T14:45:07Z

 			siteEnvelope.SiteConfig = existingSiteConfig

+			// The `AzureStorageAccounts` received does not contain `endpoint`, which is required in some cases.
+			// Since we currently do not support this property, we remove it from the payload.


technically this is

Suggested change

// Since we currently do not support this property, we remove it from the payload.

// Since the rest API spects do not contain this property, we remove it from the payload.

azurerm_logic_app_standard - remove Azurestorageaccount from update

1788701

payload

github-actions Bot added bug service/logic size/XS labels Feb 4, 2026

ziyeqf mentioned this pull request Feb 4, 2026

Logic App Standard fails to update with "Endpoint cannot be empty for File Share storage mounts" after upgrading to v4.40.0+ #31606

Open

1 task

teowa approved these changes Feb 4, 2026

View reviewed changes

ziyeqf requested a review from gerrytan February 11, 2026 23:26

gerrytan suggested changes Mar 16, 2026

View reviewed changes

Comment thread internal/services/logic/logic_app_standard_resource.go

github-actions Bot assigned gerrytan Mar 16, 2026

github-actions Bot added the waiting-response label Mar 16, 2026

azurerm_logic_app_standard - add `TestAccLogicAppStandard_fileShare…

b10fca0

…MountUpdate` test case

github-actions Bot added size/M and removed waiting-response size/XS labels Mar 16, 2026

gerrytan suggested changes Mar 16, 2026

View reviewed changes

github-actions Bot added the waiting-response label Mar 16, 2026

add azapi provider for testing

6241806

github-actions Bot removed the waiting-response label Mar 17, 2026

ziyeqf requested a review from gerrytan March 17, 2026 22:49

github-actions Bot closed this May 18, 2026

ziyeqf reopened this May 18, 2026

Merge branch 'main' into logic_app_storage

9965a60

ziyeqf marked this pull request as ready for review June 3, 2026 01:47

ziyeqf requested review from a team, WodansSon and magodo as code owners June 3, 2026 01:47

katbyte requested changes Jul 7, 2026

View reviewed changes

github-actions Bot assigned katbyte Jul 7, 2026

github-actions Bot added the waiting-response label Jul 7, 2026

update per comment

dfe89cc

github-actions Bot added size/XS and removed waiting-response size/M labels Jul 8, 2026

ziyeqf requested a review from katbyte July 8, 2026 01:11

github-actions Bot added the waiting-response label Jul 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

`azurerm_logic_app_standard` - fix issue when updating an app with file share mount#31668

`azurerm_logic_app_standard` - fix issue when updating an app with file share mount#31668
ziyeqf wants to merge 5 commits into
hashicorp:mainfrom
ziyeqf:logic_app_storage

ziyeqf commented Feb 4, 2026 •

edited

Loading

Uh oh!

teowa left a comment

Uh oh!

gerrytan left a comment

Uh oh!

Uh oh!

ziyeqf commented Mar 16, 2026

Uh oh!

gerrytan left a comment

Uh oh!

Uh oh!

gerrytan Mar 16, 2026

Uh oh!

ziyeqf Mar 17, 2026

Uh oh!

ziyeqf commented Mar 17, 2026

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

katbyte Jul 7, 2026

Uh oh!

ziyeqf Jul 8, 2026

Uh oh!

katbyte Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	// Since we currently do not support this property, we remove it from the payload.
	// Since the rest API spects do not contain this property, we remove it from the payload.

Uh oh!

Conversation

ziyeqf commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

AI Assistance Disclosure

Rollback Plan

Changes to Security Controls

Uh oh!

teowa left a comment

Choose a reason for hiding this comment

Uh oh!

gerrytan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ziyeqf commented Mar 16, 2026

Uh oh!

gerrytan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gerrytan Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

ziyeqf Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

ziyeqf commented Mar 17, 2026

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

katbyte Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

ziyeqf Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

katbyte Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ziyeqf commented Feb 4, 2026 •

edited

Loading