FE-736: JSONL session viability proof (M2)#146
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Amp-Thread-ID: https://ampcode.com/threads/T-019e4a8e-0210-76fe-9f11-8aece6190fc9 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e4b15-7745-7201-9383-57779c7738b8 Co-authored-by: Amp <amp@ampcode.com>
PR SummaryMedium Risk Overview Canonical docs advance in parallel: Reviewed by Cursor Bugbot for commit c6c33ee. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c6c33ee. Configure here.
| }) | ||
| manager.appendMessage({ role: "user", content: "Active answer" }) | ||
| return { file: manager.getSessionFile()!, activePromptId, abandonedPromptId } | ||
| } |
There was a problem hiding this comment.
RPC test uses wrong cwd for branched session
Low Severity
createBranchedSessionFile creates the session in a temp directory but doesn't return cwd. The test then passes it to readyState(file) which hardcodes cwd: "/tmp/brunch-project". The production handler in rpc.ts now passes state.cwd to loadActiveBranchTranscriptEntries, so the test exercises the production code path with a mismatched cwd. The test passes because SessionManager.open tolerates a wrong cwd when given an absolute file path, but this means the test doesn't validate that cwd propagation actually works correctly for branch resolution.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit c6c33ee. Configure here.



No description provided.