Skip to content

fix: suggestions from code review

885a006
Select commit
Loading
Failed to load commit list.
Merged

BE-434: HashQL: Refactor entity storage path resolution with centralized schema mapping #8496

fix: suggestions from code review
885a006
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 10, 2026 in 1s

62.68% (+0.03%) compared to bb10349

View this Pull Request on Codecov

62.68% (+0.03%) compared to bb10349

Details

Codecov Report

❌ Patch coverage is 82.44898% with 43 lines in your changes missing coverage. Please review.
βœ… Project coverage is 62.68%. Comparing base (bb10349) to head (885a006).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...al/hashql/mir/src/pass/execution/storage/entity.rs 61.33% 28 Missing and 1 partial ⚠️
...ibs/@local/hashql/mir/src/pass/execution/vertex.rs 68.18% 6 Missing and 1 partial ⚠️
libs/@local/hashql/mir/src/body/place.rs 0.00% 3 Missing ⚠️
...ass/execution/statement_placement/embedding/mod.rs 66.66% 1 Missing and 1 partial ⚠️
...pass/execution/statement_placement/postgres/mod.rs 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8496      +/-   ##
==========================================
+ Coverage   62.65%   62.68%   +0.03%     
==========================================
  Files        1312     1312              
  Lines      133689   133798     +109     
  Branches     5510     5511       +1     
==========================================
+ Hits        83757    83870     +113     
+ Misses      49018    49013       -5     
- Partials      914      915       +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.