Skip to content

BE-513: HashQL: Rework dynamic aggregate size estimation #8697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
indietyp wants to merge 4 commits into
base: bm/be-512-hashql-switchint-allow-cross-backend-transitions
Choose a base branch
from

chore: truncate instead of resize on mul

7cf9331
Select commit
Loading
Failed to load commit list.
Open

BE-513: HashQL: Rework dynamic aggregate size estimation #8697

chore: truncate instead of resize on mul
7cf9331
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 25, 2026 in 0s

59.17% (+0.07%) compared to 40c3c68

View this Pull Request on Codecov

59.17% (+0.07%) compared to 40c3c68

Details

Codecov Report

❌ Patch coverage is 88.67925% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.17%. Comparing base (40c3c68) to head (7cf9331).

Files with missing lines Patch % Lines
...l/mir/src/pass/analysis/size_estimation/dynamic.rs 73.49% 22 Missing ⚠️
...mir/src/pass/analysis/size_estimation/footprint.rs 92.15% 4 Missing and 4 partials ⚠️
Additional details and impacted files 
@@                                      Coverage Diff                                       @@
##           bm/be-512-hashql-switchint-allow-cross-backend-transitions    #8697      +/-   ##
==============================================================================================
+ Coverage                                                       59.10%   59.17%   +0.07%     
==============================================================================================
  Files                                                            1341     1341              
  Lines                                                          129566   129823     +257     
  Branches                                                         5849     5856       +7     
==============================================================================================
+ Hits                                                            76584    76827     +243     
- Misses                                                          52079    52090      +11     
- Partials                                                          903      906       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov