Skip to content

H-6500: Replace emoji icons in type migrations#8787

Merged
CiaranMn merged 1 commit into
mainfrom
cm/update-type-icons
May 29, 2026
Merged

H-6500: Replace emoji icons in type migrations#8787
CiaranMn merged 1 commit into
mainfrom
cm/update-type-icons

Conversation

@CiaranMn
Copy link
Copy Markdown
Member

🌟 What is the purpose of this PR?

Replaces all emoji icons in type migrations with SVG paths. Add more SVGs hosted on the frontend.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

🐾 Next steps

H-6550: Rewrite prod/staging dbs.

📹 Demo

Kapture.2026-05-29.at.14.46.04.mp4

@CiaranMn CiaranMn requested a review from TimDiekmann May 29, 2026 13:49
@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment May 29, 2026 1:50pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
hashdotdesign-tokens Ignored Ignored May 29, 2026 1:50pm
petrinaut Skipped Skipped May 29, 2026 1:50pm

@cursor
Copy link
Copy Markdown

cursor Bot commented May 29, 2026

PR Summary

Medium Risk
Changes persisted system entity type metadata (icons and Person fields); environments need migrations reapplied for existing graphs to match, but no runtime auth or data-path logic changes.

Overview
System ontology migrations now use SVG icon URLs under /icons/types/ instead of emoji (and one legacy /types/icons/... path) for Person, Doc, flow/link/claim types, and aviation entity/link types. Person also gains titlePlural: "People" and an updated description. Matching Font Awesome Pro SVG assets are added under apps/hash-frontend/public/icons/types/ so the UI can render consistent type icons.

Follow-up work (per PR notes) may require re-running migrations on prod/staging so stored type definitions pick up the new icon values.

Reviewed by Cursor Bugbot for commit bd941c3. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) type/eng > frontend Owned by the @frontend team type/eng > backend Owned by the @backend team area/apps labels May 29, 2026
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 29, 2026

🤖 Augment PR Summary

Summary: This PR replaces emoji-based ontology type icons in system-type migrations with stable SVG assets served by the frontend.

Changes:

  • Updated the Person and Doc type definitions to use SVG icon paths (and added a plural title + expanded description for Person).
  • Replaced Flow-related type emoji icons with /icons/types/*.svg URLs.
  • Updated aviation dev types to use the same SVG icon-path convention.
  • Added the referenced SVG files under apps/hash-frontend/public/icons/types.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@CiaranMn CiaranMn added this pull request to the merge queue May 29, 2026
Merged via the queue into main with commit 8ccf411 May 29, 2026
50 checks passed
@CiaranMn CiaranMn deleted the cm/update-type-icons branch May 29, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/apps type/eng > backend Owned by the @backend team type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants