Use a unique id for each file watcher registration - #5043
Open
crtschin wants to merge 1 commit into
Open
Conversation
crtschin
marked this pull request as ready for review
August 14, 2026 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4781.
Was hitting this on helix, and questioned why I keep needing to restart HLS to pick up dependency changes when switching branches for example. Found this PR, which explicitly names the issue of cabal files.
LSP doesn't indicate what should occur when a registration for the same id occurs. Some editors clobber, and others accumulate. This PR makes it so registrations are unique by their globs.