Skip to content

NetBSD: Provide workarounds for linker issues #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hebasto merged 2 commits into from
Jan 12, 2025
Merged

NetBSD: Provide workarounds for linker issues #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a2d03e
NetBSD: Set `LD_LIBRARY_PATH` environment variable when necessary
hebasto Jan 12, 2025
dae306a
NetBSD: Disable `-z separate-code` linker option
hebasto Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions .github/workflows/netbsd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ jobs:
- name: Generate buildsystem
run: |
cd ${{ github.workspace }}
cmake -B build -DCMAKE_C_COMPILER="/usr/pkg/gcc14/bin/gcc" -DCMAKE_CXX_COMPILER="/usr/pkg/gcc14/bin/g++" -DWITH_BDB=ON -DWITH_ZMQ=ON -DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DWERROR=ON
# FIXME: The `-Wl,-z,separate-code` flag is incompatible with NetBSD's dynamic linker.
cmake -B build -DCMAKE_C_COMPILER="/usr/pkg/gcc14/bin/gcc" -DCMAKE_CXX_COMPILER="/usr/pkg/gcc14/bin/g++" -DWITH_BDB=ON -DWITH_ZMQ=ON -DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DWERROR=ON -DAPPEND_LDFLAGS="-Wl,-z,noseparate-code"

- name: Build
uses: ./ci/nightly/.github/actions/build-with-ccache
Expand All @@ -72,10 +73,11 @@ jobs:
run: |
set -e
cd ${{ github.workspace }}
# TODO: Remove this line after https://github.com/bitcoin/bitcoin/pull/31543 is merged.
export LD_LIBRARY_PATH=/usr/pkg/lib
ls -l ./build/src/bitcoind
file ./build/src/bitcoind
# FIXME: The `-Wl,-z,separate-code` flag is incompatible with NetBSD.
ldd ./build/src/bitcoind || true
ldd ./build/src/bitcoind
./build/src/bitcoind -version

- name: Run test suite
Expand All @@ -87,11 +89,12 @@ jobs:
if: ${{ ! inputs.skip_functional_tests }}
run: |
cd ${{ github.workspace }}
# TODO: Fix and enable the following tests: rpc_signer.py, tool_wallet.py, wallet_signer.py.
# TODO: Remove this line after https://github.com/bitcoin/bitcoin/pull/31543 is merged.
export LD_LIBRARY_PATH=/usr/pkg/lib
# TODO: Fix and enable the following tests: rpc_signer.py, wallet_signer.py.
# See:
# - https://github.com/bitcoin/bitcoin/pull/31541
# - https://github.com/bitcoin/bitcoin/pull/31543
python3.13 build/test/functional/test_runner.py --ci --extended -j ${{ env.CI_NCPU }} --combinedlogslen=99999999 --quiet --tmpdirprefix . --timeout-factor=8 --exclude=rpc_signer.py,tool_wallet.py,wallet_signer.py
python3.13 build/test/functional/test_runner.py --ci --extended -j ${{ env.CI_NCPU }} --combinedlogslen=99999999 --quiet --tmpdirprefix . --timeout-factor=8 --exclude=rpc_signer.py,wallet_signer.py

netbsd-depends:
name: 'NetBSD: depends, no BDB, MP'
Expand Down Expand Up @@ -159,7 +162,8 @@ jobs:
- name: Generate buildsystem
run: |
cd ${{ github.workspace }}
cmake -B build --toolchain depends/$(./depends/config.guess)/toolchain.cmake -DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DWERROR=ON
# FIXME: The `-Wl,-z,separate-code` flag is incompatible with NetBSD's dynamic linker.
cmake -B build --toolchain depends/$(./depends/config.guess)/toolchain.cmake -DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DWERROR=ON -DAPPEND_LDFLAGS="-Wl,-z,noseparate-code"

- name: Build
uses: ./ci/nightly/.github/actions/build-with-ccache
Expand All @@ -172,8 +176,7 @@ jobs:
cd ${{ github.workspace }}
ls -l ./build/src/bitcoind
file ./build/src/bitcoind
# FIXME: The `-Wl,-z,separate-code` flag is incompatible with NetBSD.
ldd ./build/src/bitcoind || true
ldd ./build/src/bitcoind
./build/src/bitcoind -version

- name: Run test suite
Expand All @@ -185,8 +188,7 @@ jobs:
if: ${{ ! inputs.skip_functional_tests }}
run: |
cd ${{ github.workspace }}
# TODO: Fix and enable the following tests: rpc_signer.py, tool_wallet.py, wallet_signer.py.
# TODO: Fix and enable the following tests: rpc_signer.py, wallet_signer.py.
# See:
# - https://github.com/bitcoin/bitcoin/pull/31541
# - https://github.com/bitcoin/bitcoin/pull/31543
python3.13 build/test/functional/test_runner.py --ci --extended -j ${{ env.CI_NCPU }} --combinedlogslen=99999999 --quiet --tmpdirprefix . --timeout-factor=8 --exclude=rpc_signer.py,tool_wallet.py,wallet_signer.py
python3.13 build/test/functional/test_runner.py --ci --extended -j ${{ env.CI_NCPU }} --combinedlogslen=99999999 --quiet --tmpdirprefix . --timeout-factor=8 --exclude=rpc_signer.py,wallet_signer.py