Skip to content

[DO NOT MERGE] update co2 scaling#275

Open
jykfan wants to merge 1 commit intomasterfrom
update/co2-sensor-text
Open

[DO NOT MERGE] update co2 scaling#275
jykfan wants to merge 1 commit intomasterfrom
update/co2-sensor-text

Conversation

@jykfan
Copy link
Copy Markdown
Contributor

@jykfan jykfan commented Feb 1, 2017

Updates for CO2

  • Overview text
  • Scale text

NOT updated

  • About text
    This lives on the client

@pims
Copy link
Copy Markdown
Contributor

pims commented Feb 1, 2017

@jykfan you might want to re-enable CO2 as well?

@jykfan
Copy link
Copy Markdown
Contributor Author

jykfan commented Feb 1, 2017

@pims

  • We need to wait for update on iOS/Android first
  • Not sure how to re-enable CO2, can you point me @pims ?

@pims
Copy link
Copy Markdown
Contributor

pims commented Feb 2, 2017

@jykfan #255

@jykfan jykfan changed the title update co2 scaling [DO NOT MERGE] update co2 scaling Feb 2, 2017
@@ -12,8 +12,8 @@ public class Co2Scale extends Scale {
private static List<ScaleInterval> intervals = new ArrayList<>();
static {
intervals.add(new ScaleInterval("Ideal", "The CO2 level is just right.", 0f, 599.9f, Condition.IDEAL));
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this sentence not changed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intervals.add(new ScaleInterval("Elevated", "The CO2 level is elevated.", 600f, 1199.9f, Condition.WARNING));
intervals.add(new ScaleInterval("Unhealthy", "The CO2 level is unhealthy.", 1200f, null, Condition.ALERT));
intervals.add(new ScaleInterval("A bit stuffy", "The air is a bit stuffy.", 600f, 1199.9f, Condition.WARNING));
intervals.add(new ScaleInterval("Stuffy", "The CO2 air is stuffy.", 1200f, null, Condition.ALERT));
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the co2 air typo, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, fixing

@pims pims force-pushed the update/co2-sensor-text branch from 814a322 to 2dd3dbc Compare February 24, 2017 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants