Skip to content

fix(ios): [new arch] Module provider RNDatePickerManager does not conform to RCTModuleProvider #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hannojg wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −0
Open

fix(ios): [new arch] Module provider RNDatePickerManager does not conform to RCTModuleProvider #965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ios/RNDatePickerManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,14 @@
#import <React/RCTConvert.h>
#import <React/RCTViewManager.h>

#ifdef RCT_NEW_ARCH_ENABLED
#import <RNDatePickerSpecs/RNDatePickerSpecs.h>

@interface RNDatePickerManager : RCTViewManager <NativeRNDatePickerSpec>
#else
@interface RNDatePickerManager : RCTViewManager
#endif


@property (strong, nonatomic) UIViewController *topViewController;

Expand Down
6 changes: 6 additions & 0 deletions ios/RNDatePickerManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ @implementation RCTConvert(UIDatePicker)

@implementation RNDatePickerManager

#ifdef RCT_NEW_ARCH_ENABLED
- (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:(const facebook::react::ObjCTurboModule::InitParams &)params {
return std::make_shared<facebook::react::NativeRNDatePickerSpecJSI>(params);
}
#endif

RCT_EXPORT_MODULE(RNDatePicker)

RCT_EXPORT_METHOD(addListener : (NSString *)eventName) {
Expand Down
Loading