fix(windows): preserve remote multiline paste - #3282
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughChangesWindows Terminal paste handling
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR restores line breaks for Windows remote multiline paste while preserving unmatched report-shaped text; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Issue
A Windows user pastes multiline text with Shift+Insert or Shift+right-click during
herdr --remote. The remote pane receives one wrapped block without line breaks.Problem
Windows Terminal encoded each pasted newline as an Enter press and release report. The Windows client kept those reports as literal paste text instead of restoring the newline.
How did we fix it?
Herdr now converts the exact adjacent unmodified Enter press and release reports to one carriage return after a complete paste arrives. Other report-shaped paste text remains unchanged.
Verification
The reporter's exact input stream failed before because both Enter reports remained in the Paste event. The same test now emits one Paste with the expected line breaks, and the incomplete-pair test keeps unmatched reports unchanged. All 62 Windows input tests passed.
just checkpassed formatting, Clippy, and 3,534 of 3,535 tests; the unrelated live-handoff process-discovery test still fails alone on this VPS.refs #3209