Skip to content

Add support for aarch64_be - #476

Merged
mkroening merged 2 commits into
hermit-os:mainfrom
Gelbpunkt:aarch64_be-part1
Sep 4, 2025
Merged

Add support for aarch64_be#476
mkroening merged 2 commits into
hermit-os:mainfrom
Gelbpunkt:aarch64_be-part1

Conversation

@Gelbpunkt

Copy link
Copy Markdown
Member

No description provided.

@mkroening
mkroening self-requested a review July 29, 2025 15:13
@mkroening mkroening self-assigned this Jul 29, 2025
@Gelbpunkt
Gelbpunkt force-pushed the aarch64_be-part1 branch 2 times, most recently from 2c2cece to d57c970 Compare July 29, 2025 19:37
@Gelbpunkt
Gelbpunkt force-pushed the aarch64_be-part1 branch 2 times, most recently from 52d4b33 to a317dd3 Compare August 19, 2025 11:37
@Gelbpunkt Gelbpunkt changed the title aarch64_be fixes and preparation Add support for aarch64_be Aug 19, 2025
@Gelbpunkt
Gelbpunkt force-pushed the aarch64_be-part1 branch 2 times, most recently from 0b9d854 to f4e5f90 Compare August 19, 2025 11:44

@mkroening mkroening left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you drop the first commit and swap the order of the other two? :)

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread xtask/src/target.rs Outdated
Comment thread src/arch/aarch64/link.ld
Comment on lines -5 to -6
OUTPUT_FORMAT("elf64-littleaarch64")
OUTPUT_ARCH("aarch64")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work, but do you happen to have any knowledge on where the default value comes from and what it is now?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't, but I imagine the linker is well aware of the architecture it is linking for and therefore doesn't need this explicit hint

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

@mkroening mkroening left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@mkroening
mkroening added this pull request to the merge queue Sep 4, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 4, 2025
@mkroening
mkroening added this pull request to the merge queue Sep 4, 2025
Merged via the queue into hermit-os:main with commit 62eaf3a Sep 4, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants