feat: update accounts and accounts:current commands to use the credential manager#3689
Open
k80bowman wants to merge 12 commits intofeat/credential-mgr-integrationfrom
Open
feat: update accounts and accounts:current commands to use the credential manager#3689k80bowman wants to merge 12 commits intofeat/credential-mgr-integrationfrom
k80bowman wants to merge 12 commits intofeat/credential-mgr-integrationfrom
Conversation
This reverts commit 2d489a6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
heroku accountsandheroku accounts:currentcommands so they are able to retrieve a user's accounts from their system keychain instead of relying on the cache file used when a user's token is stored in a .netrc file. The .netrc implementation remains the same.Also fixes an issue with the
git:credentialscommand that was causing the Windows test suites to timout and fail.Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes:
Setup:
npm i && npm run build./bin/run loginHEROKU_NETRC_WRITE=true ./bin/run accounts:addto add your account to your .netrc accounts cache. Use thenamearg to give it a recognizable name, like "personal" or "work".Steps:
./bin/run accounts. You should see one account in your list, labeled with your email address, with a star next to it. This comes from the keychain.HEROKU_NETRC_WRITE=true ./bin/run accounts. You should see one account in your list, labeled with the recognizable name you chose above, with a star next to it. This comes from the .netrc accounts cache../bin/run accounts:current. You should see your account email address. This comes from the keychain.HEROKU_NETRC_WRITE=true ./bin/run accounts:current. You should see the recognizable name you gave your account above. This comes from the .netrc accounts cache.Screenshots (if applicable)
Related Issues
GUS work item: W-20867059