Skip to content

Fix stack-like behavior in 46-generic-types.md #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lexidor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix stack-like behavior in 46-generic-types.md #1416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions manual/hack/10-types/46-generic-types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,23 +9,24 @@ Consider the following example in which `Stack` is a generic class having one ty
class StackUnderflowException extends Exception {}

class Stack<T> {
private vec<T> $stack;
private int $stackPtr;

public function __construct() {
$this->stackPtr = 0;
$this->stack = vec[];
}
private vec<T> $stack = vec[];
private int $stackPtr = -1;

public function push(T $value): void {
$this->stack[] = $value;
$this->stackPtr++;
if (C\count($this->stack) === $this->stackPtr) {
$this->stack[] = $value;
} else {
$this->stack[$this->stackPtr] = $value;
}
}

public function pop(): T {
if ($this->stackPtr > 0) {
if ($this->stackPtr >= 0) {
$element = $this->stack[$this->stackPtr];
$this->stack[$this->stackPtr] = $this->stack[0];
$this->stackPtr--;
return $this->stack[$this->stackPtr];
return $element;
} else {
throw new StackUnderflowException();
}
Expand Down