refactor(tiny-transition): remove "base" class option#94
Closed
hi-ogawa wants to merge 4 commits intorefactor-tiny-transition-lagged-statefrom
Closed
Conversation
hi-ogawa
deleted the
refactor-tiny-transition-convertClassPropsToCallbackProps
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought this is an obvious refactoring but it turns out solidjs has some tricky ref/effect ordering, so we cannot simply do
ref={manager.ref}.No workaround is promising, so this PR is just for the record and I gave up.