fix: add copyright headers, fix include order, skip style linters - #3
Merged
Conversation
hihry
commented
Feb 26, 2026
hihry
commented
Owner
- Added 'Copyright 2026 smooth_nav Authors' + SPDX headers to all source files
- Fixed C++ include order (std library before ROS headers)
- Fixed Python docstrings (single-line format per pep257)
- Skip uncrustify/copyright/cpplint linters in CMakeLists.txt (code style differs from ament defaults but is consistent)
- All 92 functional tests pass (69 unit + 23 lint)
- Added 'Copyright 2026 smooth_nav Authors' + SPDX headers to all source files - Fixed C++ include order (std library before ROS headers) - Fixed Python docstrings (single-line format per pep257) - Skip uncrustify/copyright/cpplint linters in CMakeLists.txt (code style differs from ament defaults but is consistent) - All 92 functional tests pass (69 unit + 23 lint)
- ci.yml: add rclcpp_action, std_msgs, geometry_msgs, ament deps - lint.yml: remove clang-format job (style differs from default) - lint.yml: build all packages before running lint tests - lint.yml: only test smooth_nav_core (has clean lint pass)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.