Skip to content

fix: make Review action list issues without auto-fixing #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hmans merged 2 commits into from
Mar 20, 2026
+5 −3
Merged

fix: make Review action list issues without auto-fixing #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac03fbb
fix: make Review action list issues without auto-fixing
hmans Mar 20, 2026
23d5102
test: update review action test to match new prompt
hmans Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion internal/graph/agent_helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,9 @@ var agentActions = []agentActionDef{
Label: "Review",
Description: "Ask for a code review",
PromptFunc: func(_ actionContext) string {
return "Ask a subagent for a thorough code review."
return `Review the changes in this branch. Identify any issues, concerns, or suggestions, and present them as a clear list.

IMPORTANT: Do NOT fix anything automatically. Only identify and list the issues, then ask the user which ones (if any) they'd like you to address.`
},
},
{
Expand Down
4 changes: 2 additions & 2 deletions internal/graph/schema.resolvers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2989,8 +2989,8 @@ func TestExecuteAgentAction(t *testing.T) {
t.Fatal("expected session to exist")
}
lastMsg := session.Messages[len(session.Messages)-1]
if lastMsg.Content != "Ask a subagent for a thorough code review." {
t.Fatalf("expected review prompt, got: %s", lastMsg.Content)
if !strings.Contains(lastMsg.Content, "Do NOT fix anything automatically") {
t.Fatalf("expected review prompt with no-auto-fix instruction, got: %s", lastMsg.Content)
}
})

Expand Down
Loading