CI multisig#67
Open
AndreiRegiani wants to merge 28 commits into
Open
Conversation
AndreiRegiani
commented
Jun 25, 2026
AndreiRegiani
commented
Jul 1, 2026
RaisinTen
previously approved these changes
Jul 1, 2026
RaisinTen
approved these changes
Jul 2, 2026
rafapaezbas
reviewed
Jul 3, 2026
| primary-key: ${{ secrets.PEAR_PRIMARY_KEY }} | ||
| target: ${{ env.STAGE_TARGET }} | ||
|
|
||
| - name: Resolve source verlink |
Contributor
There was a problem hiding this comment.
I dont think we need this, just add the prerelease key as an input parameter to the multisig request creation step
rafapaezbas
reviewed
Jul 3, 2026
| - name: Install staging tools | ||
| run: npm install -g pear-build pear-ci-multisig corestore hyperdrive pear-link | ||
|
|
||
| - name: Build stage directory |
Contributor
There was a problem hiding this comment.
We should abstract this into its own action
rafapaezbas
reviewed
Jul 3, 2026
| echo "$verlink" | ||
| echo "source-verlink=$verlink" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Create multisig request |
Contributor
There was a problem hiding this comment.
also this could be its own action
rafapaezbas
requested changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on holepunchto/actions#85
Tested E2E in my fork with all secrets set: -> https://github.com/AndreiRegiani/hello-pear-electron/actions/runs/28509895621 (see stage summary)
$ pear multisigAction (stage summary completed)
(Fork) Settings
For signed builds:
For multisig (these values are not secrets)
Tested E2E: signed-artifact CI multisig OTA updates - macOS.dmg
-> run instructions...